Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test should build validate from the repo rather than relying on it being in $PATH #36

Open
gefjon opened this issue Oct 28, 2020 · 2 comments
Assignees

Comments

@gefjon
Copy link

gefjon commented Oct 28, 2020

The ASDF system shop3/test should depend on a validate binary as a component, and include a recipe to build it from the shop3 repo, obeying output filename translations to put the binary an ASDF build directory. Tests which invoke shop3:validate-plan should do so using :validator-progname (asdf:output-file (asdf:make-operation 'compile-op) (asdf:find-component (asdf:find-system :shop3/test) :validate)) or a similar invocation, rather than leaving :validator-progname unsupplied and expecting validate to be in the system path. This will allow contributors to run (asdf:test-system :shop3) on a fresh machine without first manually compiling and globally installing validate, and will reduce variation in Jenkins compared to testing locally.

@rpgoldman
Copy link
Contributor

If you want to submit an MR for this, please do it in the form of a sub-system (e.g., "shop3/validator") that users who want to validate plans, but don't want to run the test suite, can use.

@rpgoldman
Copy link
Contributor

Note that validate is built by the Travis tests

- pushd ${TRAVIS_BUILD_DIR}/jenkins/VAL && make && popd
which provides a pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants