Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use config File #88

Open
sudo-Tiz opened this issue Jan 27, 2024 · 1 comment
Open

Use config File #88

sudo-Tiz opened this issue Jan 27, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@sudo-Tiz
Copy link

sudo-Tiz commented Jan 27, 2024

Add the ability to use a yaml/toml configuration file.
To my point of view cli_args should either define a configuration file either define args directly.

@shizunge shizunge added the enhancement New feature or request label Jan 28, 2024
This was referenced Jan 28, 2024
@sudo-Tiz
Copy link
Author

I am working on an ansible role to integrate endlessh-go to the mash playbook . Since this playbook is designed for production use, it would be preferable for the endlessh-go code to adhere to "good practice standards," such as the utilization of a config file.
I opted for endlessh-go instead of the more popular endlessh implementation in C due to its superior log handling capabilities. However, I must emphasize that I am not proficient in go development. Therefore, I have submitted a pull request (#90), which requires review and refinement in order to cater to all possible use cases. It would be greatly appreciated if you could consider addressing this issue as a "good first issue."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants