-
-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tether-drop
does not work with v2.0
#1446
Comments
13 tasks
Hi @ericyd yes, a lot of these HubSpot libraries were all originally based on Tether. Shepherd was significantly refactored to not need it anymore, and perhaps the same should be done with Drop. These libraries used to just tether elements together can probably go away now and we can use things like https://developer.chrome.com/blog/tether-elements-to-each-other-with-css-anchor-positioning/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
tether-drop
library does not work with v2.0, but no breaking changes were announced in the release notes.Technically
tether-drop
is a separate lib and it's compatibility is not your concern, but I'm opening an issue here for two reasonstether-drop
seems entirely abandoned, whereas this lib has at least a little recent activitytether-drop
liberally, and I imagine a new user of this lib would be a little confused at the incompatibilityTechnical
Tether.Utils
(reference)Tether.Utils
does not exist in the new version (reference)Recommendation
This could probably be somewhat easily resolved by adding back a
Tether.Utils
declaration similar to the original.However, please note that tether-drop also relies on
extend
, which appears to have been removed in v2.0.0.If you're interested in a solution like this, let me know and I can try to open a PR. I'd probably just copy-paste the extend function from v1.4.7 since it's pretty small and self-contained.
Thanks for your time and energy 🙂
The text was updated successfully, but these errors were encountered: