Allow use get property hook in interface on readonly property #(300)

Author: David Jelínek

src/Rule/EnforceReadonlyPublicPropertyRule.php

@@ -52,6 +52,22 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
+        if ($this->phpVersion->supportsPropertyHooks()) {
+            foreach ($node->getHooks() as $hook) {
+                if ($hook->name->toString() === 'set') {
+                    $error = RuleErrorBuilder::message("Public property `{$node->getName()}` cannot have a setter hook, because is mark as readonly.")
+                        ->identifier('shipmonk.publicPropertyNotReadonly')
+                        ->build();
+
+                    return [$error];
+                }
+            }
+
+            if ($classReflection->isInterface()) {
+                return [];
+            }
+        }
+
         $error = RuleErrorBuilder::message("Public property `{$node->getName()}` not marked as readonly.")
             ->identifier('shipmonk.publicPropertyNotReadonly')
             ->build();

tests/Rule/EnforceReadonlyPublicPropertyRuleTest.php

@@ -5,6 +5,7 @@
 use PHPStan\Php\PhpVersion;
 use PHPStan\Rules\Rule;
 use ShipMonk\PHPStan\RuleTestCase;
+use const PHP_VERSION_ID;
 
 /**
  * @extends RuleTestCase<EnforceReadonlyPublicPropertyRule>
@@ -20,6 +21,16 @@ protected function getRule(): Rule
         return new EnforceReadonlyPublicPropertyRule($this->phpVersion);
     }
 
+    public function testPhp84(): void
+    {
+        if (PHP_VERSION_ID < 80_400) {
+            self::markTestSkipped('Test requires PHP 8.4.');
+        }
+
+        $this->phpVersion = $this->createPhpVersion(80_400);
+        $this->analyseFile(__DIR__ . '/data/EnforceReadonlyPublicPropertyRule/code-84.php');
+    }
+
     public function testPhp81(): void
     {
         $this->phpVersion = $this->createPhpVersion(80_100);

tests/Rule/data/EnforceReadonlyPublicPropertyRule/code-84.php

@@ -0,0 +1,62 @@
+<?php
+
+namespace EnforceReadonlyPublicPropertyRule84;
+
+interface I
+{
+    public string $key { get; }
+    public int|float|string $value { get; set; } // error: Public property `value` cannot have a setter hook, because is mark as readonly.
+}
+
+// there is DiscriminatorMap Attribute from symfony
+abstract readonly class A implements I
+{
+}
+
+readonly class B
+{
+    public function __construct(
+        public string $key,
+        public int $value,
+    ) {
+    }
+}
+readonly class C
+{
+    public function __construct(
+        public string $key,
+        public string $value,
+    ) {
+    }
+}
+readonly class D
+{
+    public function __construct(
+        public string $key,
+        public int $value,
+    ) {
+    }
+}
+
+
+class X
+{
+    /**
+     * @param array<A> $foo
+     */
+    public function __construct(
+        public readonly array $foo = [],
+    ) {
+    }
+
+    public function getFirstKeyOfFloat(): ?string
+    {
+        foreach ($this->foo as $item) {
+            if (is_float($item->value)) {
+                return $item->key;
+            }
+        }
+        return null;
+    }
+}
+