Skip to content

Latest commit

 

History

History
40 lines (22 loc) · 2.78 KB

contributing.md

File metadata and controls

40 lines (22 loc) · 2.78 KB
Raw

Contributing

We welcome bug reports, feature requests and pull requests. If you want to help us out, please follow these guidelines, in order to avoid redundant work.

Support

Before asking questions, read our documentation and FAQ.

If these doesn't answer your question

  • Use Stack Overflow for questions that doesn't directly involve Plyr. This includes for example how to use Javascript, CSS or HTML5 media in general, and how to use other frameworks, libraries and technology.
  • Use our Slack if you need help using Plyr or have questions about Plyr.

Commenting

When commenting, keep a civil tone and stay on topic. Don't ask for support, or post "+1" or "I agree" type of comments. Use the emojis instead.

Asking for the status on issues is discouraged. Unless someone has explicitly said in an issue that it's work in progress, most likely that means no one is working on it. We have a lot to do, and it may not be a top priority for us.

We may moderate discussions. We do this to avoid threads being "hijacked", to avoid confusion in case the content is misleading or outdated, and to avoid bothering people with github notifications.

Creating issues

Please follow the instructions in our issue templates. Don't use github issues to ask for support.

Contributing features and documentation

  • If you want to add a feature or make critical changes, you may want to ensure that this is something we also want (so you don't waste your time). Ask us about this in the corresponding issue if there is one, or on our Slack otherwise.

  • Fork Plyr, and create a new branch in your fork, based on the develop branch

  • To test locally, you can use the demo. First make sure you have installed the dependencies with npm install or yarn. Run gulp to build while you are working, and run a local server from the repository root directory. If you have Python installed, this command should work: python -m SimpleHTTPServer 8080. Then go to http://localhost:8080/demo/

  • Develop and test your modifications.

  • Preferably commit your changes as independent logical chunks, with meaningful messages. Make sure you do not commit unnecessary files or changes, such as the build output, or logging and breakpoints you added for testing.

  • If your modifications changes the documented behavior or add new features, document these changes in readme.md.

  • When finished, push the changes to your GitHub repository and send a pull request to develop. Describe what your PR does.

  • If the Travis build fails, or if you get a code review with change requests, you can fix these by pushing new or rebased commits to the branch.