Skip to content

Commit 41021ac

Browse files
committed
style: optimize ui
1 parent cc3ca48 commit 41021ac

File tree

4 files changed

+20
-23
lines changed

4 files changed

+20
-23
lines changed

src/pages/app/components/Limit/LimitModify/Sop/Step1.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { t } from "@app/locale"
2-
import { ElCol, ElForm, ElFormItem, ElInput, ElOption, ElRow, ElSelect, ElSwitch } from "element-plus"
2+
import { ElCol, ElForm, ElFormItem, ElInput, ElRow, ElSelect, ElSwitch } from "element-plus"
33
import { defineComponent } from "vue"
44
import { useSopData } from "./context"
55

@@ -31,9 +31,8 @@ const _default = defineComponent(() => {
3131
modelValue={data.weekdays}
3232
onChange={v => data.weekdays = v}
3333
placeholder=""
34-
>
35-
{t(msg => msg.calendar.weekDays).split('|').map((weekDay, idx) => <ElOption value={idx} label={weekDay} />)}
36-
</ElSelect>
34+
options={t(msg => msg.calendar.weekDays).split('|').map((label, idx) => ({ value: idx, label }))}
35+
/>
3736
</ElFormItem>
3837
</ElCol>
3938
</ElRow>

src/pages/app/components/Limit/LimitModify/Sop/Step2/SiteInput.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ const fetchAllHosts = async () => {
3030
const useUrlSelect = () => {
3131
const { data: allHosts } = useRequest(fetchAllHosts)
3232
const [input, onFilter] = useDebounceState('', 50)
33-
const selectEl = ref<SelectV2Instance>()
3433
const inputUrl = computed(() => {
3534
const inputVal = input.value
3635
return inputVal ? cleanCond(inputVal) : undefined

src/pages/popup/components/Footer/index.tsx

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import DurationSelect from "@popup/components/Footer/DurationSelect"
44
import { useQuery } from "@popup/context"
55
import { t } from "@popup/locale"
66
import { ALL_DIMENSIONS } from "@util/stat"
7-
import { ElOption, ElSelect, ElText } from "element-plus"
7+
import { ElSelect, ElText } from "element-plus"
88
import { defineComponent } from "vue"
99
import Menu from "./Menu"
1010

@@ -28,12 +28,11 @@ const Footer = defineComponent(() => {
2828
placeholder={t(msg => msg.shared.merge.mergeMethod.notMerge)}
2929
popperOptions={{ placement: 'top' }}
3030
style={{ width: '90px' }}
31-
>
32-
<ElOption value='' label={t(msg => msg.shared.merge.mergeMethod.notMerge)} />
33-
{mergeItems.value.map(method => (
34-
<ElOption value={method} label={t(msg => msg.shared.merge.mergeMethod[method])} />
35-
))}
36-
</ElSelect>
31+
options={[
32+
{ value: '', label: t(msg => msg.shared.merge.mergeMethod.notMerge) },
33+
...mergeItems.value.map(value => ({ value, label: t(msg => msg.shared.merge.mergeMethod[value]) })),
34+
]}
35+
/>
3736
</Flex>
3837
<DurationSelect
3938
reverse
@@ -48,9 +47,8 @@ const Footer = defineComponent(() => {
4847
onChange={v => query.dimension = v}
4948
popperOptions={{ placement: 'top' }}
5049
style={{ width: '120px' }}
51-
>
52-
{ALL_DIMENSIONS.map(item => <ElOption value={item} label={t(msg => msg.item[item])} />)}
53-
</ElSelect>
50+
options={ALL_DIMENSIONS.map(value => ({ value, label: t(msg => msg.item[value]) }))}
51+
/>
5452
</Flex>
5553
</Flex >
5654
)

src/pages/popup/components/Percentage/chart.ts

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,9 @@ function calculateSubTitleText(result: PercentageResult): string {
7676
let { date, dataDate, rows, query: { dimension, duration } = {}, dateLength } = result
7777
const dateStr = dataDate ? formatDateStr(date, dataDate) : ''
7878
const totalStr = formatTotalStr(rows, dimension)
79+
let firstLineParts = [totalStr, dateStr].filter(s => !!s)
80+
isRtl() && (firstLineParts = firstLineParts.reverse())
81+
const firstLine = firstLineParts.join(' ')
7982

8083
// Calculate average per day
8184
let averageStr = ''
@@ -88,29 +91,27 @@ function calculateSubTitleText(result: PercentageResult): string {
8891
const total = sum(rows.map(r => r?.focus ?? 0))
8992
const averagePerDay = total / dateLength
9093
const averageTime = formatPeriodCommon(averagePerDay)
91-
averageStr = '(' + t(msg => msg.content.percentage.averageTime, { value: averageTime }) + ')'
94+
averageStr = t(msg => msg.content.percentage.averageTime, { value: averageTime })
9295
} else if (dimension === 'time') {
9396
// Average visits per day
9497
const totalCount = sum(rows.map(r => r.time ?? 0))
9598
const averagePerDay = totalCount / dateLength
9699
const averageCount = averagePerDay.toFixed(1)
97-
averageStr = '(' + t(msg => msg.content.percentage.averageCount, { value: averageCount }) + ')'
100+
averageStr = t(msg => msg.content.percentage.averageCount, { value: averageCount })
98101
}
99102
}
100103

101-
let parts = [totalStr, dateStr, averageStr].filter(str => !!str)
102-
isRtl() && (parts = parts.reverse())
103-
return parts.join(' ')
104+
return [firstLine, averageStr].filter(s => !!s).join('\n')
104105
}
105106

106107
export function generateTitleOption(result: PercentageResult, suffix?: string): TitleComponentOption {
107108
return {
108109
text: [result?.chartTitle, suffix].filter(v => !!v).join(' - '),
109110
subtext: calculateSubTitleText(result),
110-
left: 'center',
111111
textStyle: { color: getPrimaryTextColor() },
112-
subtextStyle: { color: getSecondaryTextColor() },
113-
top: 15,
112+
subtextStyle: { color: getSecondaryTextColor(), lineHeight: 15, fontSize: 12 },
113+
left: 'center',
114+
top: 14,
114115
}
115116
}
116117

0 commit comments

Comments
 (0)