Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sent notifications (reminder) before event #73

Open
rmaree opened this issue May 31, 2023 · 3 comments
Open

feat: sent notifications (reminder) before event #73

rmaree opened this issue May 31, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@rmaree
Copy link
Contributor

rmaree commented May 31, 2023

notifications for events are sent when it is created, should also send a reminder before the event ?

@rmaree rmaree added the enhancement New feature or request label May 31, 2023
@rmaree rmaree changed the title feat: sent notifications before event feat: sent notifications (reminder) before event Jun 27, 2023
@banneux-florent
Copy link
Collaborator

So notifications would be sent to everyone within the notification radius? What if someone don't want to get reminders from events? New setting in account settings? Adding a "Remind it to me later" button on the events item page?

@rmaree
Copy link
Contributor Author

rmaree commented Oct 31, 2023

A kind of "Subscription" ("remind it to me later") option might be something we could think about in a more general perspective (not only event) because we are also thinking about notifications when something happens (new comment or any new "activity"...) related to any item/publicresource on the platform. That's a mid-term development goal.

A short-term approach would be an option on the notifications settings page where the user would select event reminders: yes/no (in addition to the current notifications settings instantly/daily/weekly/never). Then a daily scheduler would get for the user if reminder=yes its local events (< radius) that will occur in less than 24h to send the reminder ?

@banneux-florent
Copy link
Collaborator

banneux-florent commented Nov 1, 2023

Totally agree.

But to be precise I wouldn't do a less than 24h verification, in some specific cases it could lead to an almost no gap time between event start and the reminder.

Instead, I would go for a scheduler that activates arbitrarily during the day, far enough from midnight, and that checks for all the events occurring the next day. It would leave a "security time gap" between the reminder and the event.

Hope it's clear..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants