Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improving VueJS routes #142

Open
banneux-florent opened this issue Mar 18, 2024 · 2 comments · May be fixed by #143
Open

feat: improving VueJS routes #142

banneux-florent opened this issue Mar 18, 2024 · 2 comments · May be fixed by #143
Assignees
Labels
enhancement New feature or request javascript Pull requests that update Javascript code

Comments

@banneux-florent
Copy link
Collaborator

banneux-florent commented Mar 18, 2024

Somes routes could be using regex to improve user experience and prevent bad requests to be sent to the server. For example, we could verify that ids are positive intergers, that tokens match the token pattern, etc..

Routes that will still need to be done:

  • name: resetPasswordConfirm, path: /reset-password/confirm/:uid/:token (can't confirm 100% know uid and token pattern)
  • name: activateEmailToken, path: /activate/:uid/:token (can't confirm 100% know uid and token pattern)
  • name: addItemPos, path: /add-item/pos/:lat/:lng/:type/:resource/:rid (don't know last 3 possible value/pattern)
@banneux-florent banneux-florent added enhancement New feature or request javascript Pull requests that update Javascript code labels Mar 18, 2024
@banneux-florent banneux-florent self-assigned this Mar 18, 2024
@banneux-florent banneux-florent linked a pull request Mar 18, 2024 that will close this issue
@banneux-florent banneux-florent linked a pull request Mar 18, 2024 that will close this issue
@rmaree
Copy link
Contributor

rmaree commented Mar 21, 2024

Thanks.

Here are more information about the last one:
name: addItemPos, path: /add-item/pos/:lat/:lng/:type/:resource/:rid (don't know last 3 possible value/pattern)

--> This is a route for adding a request or donation linked to a public resource (e.g. add a request to clean a solidarity fridge)

:type is an item type usually string RQ (request) or DN (donation)
:resource is a public resource type (string as defined in extraCategories in TheMapView)
:rid is an numerical identifier of a public resource, in the case of OSM it is the identifier of a node encoded as a 64-bit integer >=1

@banneux-florent
Copy link
Collaborator Author

Thanks.

Here are more information about the last one: name: addItemPos, path: /add-item/pos/:lat/:lng/:type/:resource/:rid (don't know last 3 possible value/pattern)

--> This is a route for adding a request or donation linked to a public resource (e.g. add a request to clean a solidarity fridge)

:type is an item type usually string RQ (request) or DN (donation) :resource is a public resource type (string as defined in extraCategories in TheMapView) :rid is an numerical identifier of a public resource, in the case of OSM it is the identifier of a node encoded as a 64-bit integer >=1

Missing verifications have been added to this route and are now available in the open pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants