Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify Add/Edit Item to reset the form #154

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

modify Add/Edit Item to reset the form #154

wants to merge 2 commits into from

Conversation

AdrienHoyoux
Copy link
Collaborator

I've added the icons and added location deletion for the form reset, as well as solved the problems for the Edit Item form reset.

@AdrienHoyoux AdrienHoyoux requested a review from rmaree April 3, 2024 08:48
@AdrienHoyoux AdrienHoyoux linked an issue Apr 3, 2024 that may be closed by this pull request
feat: button reset-form + delete location in add/edit item #140
Open
@rmaree
Copy link
Contributor

rmaree commented Apr 16, 2024

I suggest to use icon for the reset form button.
In the edititem vue, the buttons are expanded with a very large width, reduce their size and put them on a same line? Maybe we could reduce the button text also in particular in french ? "reinitialiser le formulaire" -> "réinitialiser" ? "publier l'élément" -> "publier" ?

@AdrienHoyoux
change button size in editItem
165b49b 
The width of the buttons adapts to the larger one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmaree rmaree Awaiting requested review from rmaree

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: button reset-form + delete location in add/edit item
2 participants
@AdrienHoyoux @rmaree