Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underspecified docker errors #37

Open
ScottFreeCode opened this issue Oct 18, 2021 · 0 comments
Open

Underspecified docker errors #37

ScottFreeCode opened this issue Oct 18, 2021 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@ScottFreeCode
Copy link
Contributor

ScottFreeCode commented Oct 18, 2021

Sometimes when a container has catastrophically failed, Touchstone goes to stop it as part of network shutdown and spits out an error saying no such container. This isn't very detailed and isn't obvious to all developers that the real issue is the container died when it attempted to start up. (In contrast, a healthcheck never passing spits out a whole stack trace where all we need to know is which container's healthcheck never became healthy.)

Would it be possible to catch the Docker missing container error and provide a message saying which mock or service died or wasn't started, and ensure this does not block shutting down the rest of the network?

(Relatedly I would expect a similarly informative error if the Docker command to build or to start/run the container in the first place errors; it's been a while since I had that happen so I don't recall what it looks like, though I think it may be reproducible by attempting to run while the app's port is already allocated to another app or instance.)

@shanejansen shanejansen added this to the 1.4.1 milestone Oct 22, 2021
@shanejansen shanejansen added the enhancement New feature or request label Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants