Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: does not return image not found error #32

Open
hdev72 opened this issue Jul 2, 2022 · 1 comment
Open

Bug: does not return image not found error #32

hdev72 opened this issue Jul 2, 2022 · 1 comment

Comments

@hdev72
Copy link

hdev72 commented Jul 2, 2022

hello dear friends
when i request to load unavailable image, davinci does not return error and returns Image has been loaded.

here is my code

Davinci.get()
.load(imgUrl)
.into(into)
.setErrorPlaceholder(errorSprite)
.setFadeTime(0) // 0 for disable fading
.withStartAction(() =>
{
H.log(TAG, "Download has been started.");
})
.withDownloadProgressChangedAction((progress) =>
{
H.log(TAG, "Download progress: " + progress);
})
.withDownloadedAction(() =>
{
H.log(TAG, "Download has been completed.");
})
.withLoadedAction(() =>
{
H.log(TAG, "Image has been loaded.");
// //H.log("into.sprit:" + into.sprite );
if(!avatarHistory.ContainsKey(avatarName)){
avatarHistory.Add(avatarName, into.sprite);
}
})
.withErrorAction((error) =>
{
H.log(TAG, "loadAvatarImage error:" + error);
if(gender == 0){
into.sprite = Resources.Load("avatar_boy");
}else{
into.sprite = Resources.Load("avatar_girl");
}
})
.withEndAction(() =>
{
H.log(TAG, "Operation has been finished.");
})
.start();

@hdev72
Copy link
Author

hdev72 commented Jul 2, 2022

simple resolve: but maybe not good:

i added this codes to private IEnumerator Downloader() method:

    string response = System.Text.Encoding.ASCII.GetString(www.bytes);
    Debug.Log("[Davinci] urlResponse : " + response);
    if(response.ToLower().Contains("not found")){
        error("Not Found");
        yield return null;
    }else{

        if (www.error == null)
            File.WriteAllBytes(filePath + uniqueHash, www.bytes);
            
            

        www.Dispose();
        www = null;

        if (onDownloadedAction != null)
            onDownloadedAction.Invoke();

        loadSpriteToImage();

        underProcessDavincies.Remove(uniqueHash);
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant