Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated testing #24

Open
Techie-Pi opened this issue Aug 10, 2021 · 4 comments
Open

Automated testing #24

Techie-Pi opened this issue Aug 10, 2021 · 4 comments

Comments

@Techie-Pi
Copy link
Contributor

An interesting thing to add will be automated testing using something similar to Github Actions to make sure changes to the script don't break the builds.

We could use a simple workflow just to build the examples of the project and test them (example). Or we could go a step forward and write tests and use something like game-ci/unity-test-runner (example) for the script, although I don't have experience writing tests with Unity.

The only requirement to do this is to create a new Unity account, download the personal license and add it to the secrets of the repo (so that Unity could be downloaded and thus build the project).

If @shamsdev approves this idea, we should wait until the PR that supersedes #20 is merged to prevent more problems merging it

@Techie-Pi
Copy link
Contributor Author

Techie-Pi commented Aug 10, 2021

And obviously, if this idea is approved I will create a PR with the workflow

@shamsdev
Copy link
Owner

That is a great idea. Thank you @Techie-Pi
I do my best to help

@Techie-Pi
Copy link
Contributor Author

Great! I'll be outside my home for a few days, but when I come back I'll start working on this feature

@Techie-Pi
Copy link
Contributor Author

Techie-Pi commented Sep 17, 2021

I'm starting high school, so I won't have much time to work in this, but I will notify any progress I make

Edit: Wow, it's been some time! A lot has happened, and I don't even have access to Unity now, so... I guess the "I'll come back soon" didn't happen :(
This would be nice if someone wants to try tho!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants