Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert the NPM package to Typescript #200

Open
alexeyr-ci1 opened this issue Nov 2, 2022 · 2 comments
Open

Convert the NPM package to Typescript #200

alexeyr-ci1 opened this issue Nov 2, 2022 · 2 comments
Assignees
@alexeyr-ci1
Labels
enhancement help wanted

Comments

@alexeyr-ci1
Copy link
Collaborator

Convert https://github.com/shakacode/shakapacker/tree/master/package to use Typescript. In addition to catching possible errors, it will be nicer to consume in other projects (whether they use TS themselves or not).
@alexeyr-ci1 alexeyr-ci1 self-assigned this Nov 2, 2022
@alexeyr-ci1 alexeyr-ci1 changed the title Include types in the NPM package Convert the NPM package to Typescript Nov 2, 2022
@ahangarha
Copy link
Contributor

@justin808
If we want to do this, I would like to do it.
In this case, should it be done for v7.0.0 or it can be done for some minor release? 🤔

@alexeyr-ci
Copy link
Contributor

We currently only added a .d.ts file which has to be maintained (and I don't think is complete). Reopening for the complete conversion.

@alexeyr-ci alexeyr-ci reopened this Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexeyr-ci1 alexeyr-ci1

Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Judahmeek @ahangarha @alexeyr-ci @alexeyr-ci1