You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Context: the current docs deliberately say to pin to the project major version, but using the exact workspace packageManager version would make the example more reproducible.
Suggested change: RUN corepack enable && corepack prepare pnpm@10.33.4 --activate # match the packageManager field in package.json
package.json:162 - Add an inline note explaining why protobufjs is intentionally excluded from pnpm.onlyBuiltDependencies.
Context: the PR description explains that protobufjs has a postinstall version-scheme warning, not a build step. Capturing that inline may help future contributors who run pnpm ignored-builds.
Suggested note: protobufjs: intentionally NOT listed - its postinstall is a version-scheme warning, not a build step.
Optional review feedback
These items came from optional review feedback on PR #3421. They are non-blocking, but worth considering for a future cleanup pass.
docs/oss/deployment/docker-deployment.md:113- Pin the Docker example frompnpm@10topnpm@10.33.4.packageManagerversion would make the example more reproducible.RUN corepack enable && corepack prepare pnpm@10.33.4 --activate # match the packageManager field in package.jsonpackage.json:162- Add an inline note explaining whyprotobufjsis intentionally excluded frompnpm.onlyBuiltDependencies.protobufjshas a postinstall version-scheme warning, not a build step. Capturing that inline may help future contributors who runpnpm ignored-builds.protobufjs: intentionally NOT listed - its postinstall is a version-scheme warning, not a build step.Original PR: #3421