Skip to content

Follow-up: Review feedback from PR #3421 #3437

@justin808

Description

@justin808

Optional review feedback

These items came from optional review feedback on PR #3421. They are non-blocking, but worth considering for a future cleanup pass.

  1. docs/oss/deployment/docker-deployment.md:113 - Pin the Docker example from pnpm@10 to pnpm@10.33.4.

    • Original comment: chore: add pnpm 10 build allowlist and update Docker example #3421 (comment)
    • Context: the current docs deliberately say to pin to the project major version, but using the exact workspace packageManager version would make the example more reproducible.
    • Suggested change: RUN corepack enable && corepack prepare pnpm@10.33.4 --activate # match the packageManager field in package.json
  2. package.json:162 - Add an inline note explaining why protobufjs is intentionally excluded from pnpm.onlyBuiltDependencies.

    • Original comment: chore: add pnpm 10 build allowlist and update Docker example #3421 (comment)
    • Context: the PR description explains that protobufjs has a postinstall version-scheme warning, not a build step. Capturing that inline may help future contributors who run pnpm ignored-builds.
    • Suggested note: protobufjs: intentionally NOT listed - its postinstall is a version-scheme warning, not a build step.

Original PR: #3421

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions