-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto add first 7 characters of the commit by default #117
Comments
I think we shouldn't make the default behavior dependent on git. I think the better approach is to have the incremental image tag as the default, but also have ways to set the method of calculating the image tag in the configuration file. Also, I think the current In case it is important to know git commit hash in the deployed project in runtime, we may look for ways to pass custom args while building images. |
should we change build-image without option --commit to default to call git to get the local commit sha?
https://github.com/shakacode/heroku-to-control-plane/blob/main/lib/command/build_image.rb
HiChee does:
For Github action, that would be
(https://chat.openai.com/share/7be4d077-9dab-4fab-b03d-b68ab057230b)
How about if we do this if the commit is not specified?
and get the commit and take the first 7 chars?
Maybe need to allow choosing the number of chars?
Maybe allow turning this off with --no-commit-in-name?
The text was updated successfully, but these errors were encountered: