AD Cleanup: Fix confusing naming conventions for synthesized methods and types #4178
Labels
goal:quality & productivity
Quality issues and issues that impact our productivity coding day to day inside slang
kind:cleanup
tech debt and rough edges
priority:medium
nice to have in next milestone
Milestone
Synthesized methods and types are assigned names in different places and are somewhat inconsistent with their intent.
For instance, the primal context generation function also starts with
s_bwd
, which can be particularly confusing since it does not compute any derivatives. Probably a good idea to change this tos_primal_ctx
or something similar, and have a single point where name synthesis is handledAdditionally,
s_diff_
is appended to all processed types even if the type is used as its own differential. This causes existing type names to be overwritten or certain types to have long chains ofs_diff_s_diff_...
appended to their names. We should clean this up.The text was updated successfully, but these errors were encountered: