Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AD Cleanup: Fix confusing naming conventions for synthesized methods and types #4178

Open
saipraveenb25 opened this issue May 16, 2024 · 0 comments
Assignees
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang kind:cleanup tech debt and rough edges priority:medium nice to have in next milestone

Comments

@saipraveenb25
Copy link
Collaborator

Synthesized methods and types are assigned names in different places and are somewhat inconsistent with their intent.

For instance, the primal context generation function also starts with s_bwd, which can be particularly confusing since it does not compute any derivatives. Probably a good idea to change this to s_primal_ctx or something similar, and have a single point where name synthesis is handled

Additionally, s_diff_ is appended to all processed types even if the type is used as its own differential. This causes existing type names to be overwritten or certain types to have long chains of s_diff_s_diff_... appended to their names. We should clean this up.

@saipraveenb25 saipraveenb25 added kind:cleanup tech debt and rough edges priority:medium nice to have in next milestone goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang labels May 16, 2024
@saipraveenb25 saipraveenb25 added this to the Q2 2024 (Spring) milestone May 16, 2024
@saipraveenb25 saipraveenb25 self-assigned this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang kind:cleanup tech debt and rough edges priority:medium nice to have in next milestone
Projects
None yet
Development

No branches or pull requests

2 participants