Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure performance profiler is disabled in production environment #4167

Closed
csyonghe opened this issue May 14, 2024 · 2 comments
Closed

Make sure performance profiler is disabled in production environment #4167

csyonghe opened this issue May 14, 2024 · 2 comments
Assignees
@kaizhangNV
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang
Milestone
Q2 2024 (Spring)

Comments

@csyonghe
Copy link
Collaborator

No description provided.

@csyonghe csyonghe added the goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang label May 14, 2024
@csyonghe csyonghe added this to the Q2 2024 (Spring) milestone May 14, 2024
kaizhangNV added a commit to kaizhangNV/slang that referenced this issue May 24, 2024
@kaizhangNV
Disable slang profiler in production build
9738c7d 
Fix issue shader-slang#4167.

Add `--production-build=true` in our build system to indicate
the production build which is ONLY used when publish a new release.

In production build, we will disable the SLANG_PROFILER.
@kaizhangNV kaizhangNV mentioned this issue May 24, 2024
Draft
@kaizhangNV
Copy link
Contributor

Close this task as we might need more discussion on whether we want to disable it or extend it to a more hierarchical and optional way.

@kaizhangNV
Copy link
Contributor

Current related change is here: #4221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaizhangNV kaizhangNV

Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang
Projects
None yet
Milestone
Q2 2024 (Spring)
Development

No branches or pull requests
2 participants
@csyonghe @kaizhangNV