Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Falcor Compilation to SPIR-V with no Inlining #4157

Open
sriramm-nv opened this issue May 13, 2024 · 0 comments
Open

Falcor Compilation to SPIR-V with no Inlining #4157

sriramm-nv opened this issue May 13, 2024 · 0 comments
Assignees
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang kind:performance things we wish were faster priority:medium nice to have in next milestone

Comments

@sriramm-nv
Copy link
Collaborator

Problem Statement
Falcor provides a wide set of shaders that can be compiled via Slang, to generate SPIR-V. The direct-spirv lowering path, bypasses glslang, and stands as a first-class compilation pipeline for outputting SPIR-V code.
However, currently, there is a need for performing spirv-opt on this SPIR-V output code, in order to generate a more-compact output, for further lowering via GLV compilation pipeline. The main purpose of spirv-opt is to perform Inlining of the functions, and this currently adds compilation time overhead for each shader that goes through the pipeline.

Work to be done

  1. Disable spirv-opt for the Falcor shader compilation via Direct SPIR-V emit.
    a. Use Vulkan backend
    b. Use Direct SPIR-V backend instead of Glslang
    c. Disable SPIR-V optimization (Use -O0)
  2. Identify bugs during compilation
    a. Report bugs to GLV team with appropriate container files for repro.
    b. Pick up bugs and fix as needed.
@sriramm-nv sriramm-nv added kind:performance things we wish were faster priority:medium nice to have in next milestone goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang labels May 13, 2024
@sriramm-nv sriramm-nv self-assigned this May 13, 2024
@csyonghe csyonghe added this to the Q2 2024 (Spring) milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang kind:performance things we wish were faster priority:medium nice to have in next milestone
Projects
None yet
Development

No branches or pull requests

2 participants