Bootstrap 4 and Bootstrap 5 validation

[thewebartisan7]

I would like to use bootstrap 4 and bootstrap 5 default validation classes, but seem not possible.

For display .invalid-feedback the input must have .is-invalid or .valid-feedback with .is-valid, example:

<div class="form-group">
      <input type="text" class="form-control is-invalid" required="">
      <div class="invalid-feedback">This field is required</div>
</div>

<div class="form-group">
      <input type="text" class="form-control is-valid" required="">
      <div class="valid-feedback">Looks good</div>
</div>

If I change the default class name like so:

    let validator = new Pristine(form, {
        classTo: 'form-group',
        errorClass: 'is-invalid',
        successClass: 'is-valid',
        errorTextParent: 'form-group',
        errorTextTag: 'div',
        errorTextClass: 'invalid-feedback'
    })

The errors is not visible because class .is-invalid is not added to input but to form-group, example:

<div class="form-group is-invalid">
            <label for="email">E-Mail Address</label>
            <input type="email" id="email" name="email" class="form-control" required="">
            <div class="pristine-error invalid-feedback">This field is required</div>
</div>

I could solve this by adding extra CSS like .is-invalid .invalid-feedback {display: block} (not completely because need also to consider input group border, dark theme of bootstrap 5, etc). Would be good to have a way to do this without extra CSS, if possible without breaking change.

Bootstrap has also a class .was-validated, that show invalid feedback depending on HTML5 validation, like .was-validated :invalid ~ .invalid-feedback {display: block}

But this doesn't work for example with input type email where HTML5 consider valid email@example while pristine correctly mark this as invalid.

[thewebartisan7]

Here is mixin of form state that should be used to change style:
https://github.com/twbs/bootstrap/blob/main/scss/mixins/_forms.scss

There are different other things to consider if changing style to cover this.

[thewebartisan7]

I make here a PR: #43

I just add success/error class to input, by keeping the same on parent.

[sha256]

@thewebartisan7, I think there's an easier way to solve this problem. error & success classes are added to the element you specify in classTo property. So if you change from classTo: 'form-group' to classTo: 'form-control' it should work but there's one problem: It looks for an ancestor of the input field with class classTo. This can be easily solved by fixing the findAncestor method.

[thewebartisan7]

Ah, let me try.

I think that we can fix findAncestor like this:

export function findAncestor (el, cls) {

    // Check before in current el before check in parent
    if(!el.classList.contains(cls))
        while ((el = el.parentElement) && !el.classList.contains(cls));

    return el;
}

This was first thing that I looks into, but didn't test.

I will check now.

Anyway, I notice that when I install via NPM is not the actual version that I see here in github, for example is missing equals and some other change.

[thewebartisan7]

Nope, this doesn't work. Almost not how I change findAncestor.

First the errors is not added, only input receive class is-invalid.

But another error is that checkbox or radio input has not form-control but form-check-input

Then is not found by findAncestor and appear error:

TypeError: errorClassElement is null

[sha256]

checkbox or radio input not having form-control can be solved by giving all inputs a custom class and specify it in classTo.

Errors are added based on errorTextParent.

I'll create a codepen and check in detail. If you already have something, please share it with me.

[sha256]

I think I got the issue:
Apart from the findAncestor change, the following code:

        if (self.config.classTo === self.config.errorTextParent){
            errorTextParent = errorClassElement;
        } else {
            errorTextParent = errorClassElement.querySelector('.' + self.config.errorTextParent);
        }

needs to be changed to:

var errorTextParent = findAncestor(field.input, self.config.errorTextParent),
      errorTextElement = null;

I'll check if there's any side effects and make the change. The solution you proposed may have side effects because of adding the same class to parent and child. That's why I'm looking for a different approach.

[thewebartisan7]

checkbox or radio input not having form-control can be solved by giving all inputs a custom class and specify it in classTo.

Yes this can be a solution also to fix issue that happen right now where also fields that doesn't require validation, example a not required input, receive a is-valid class, then become green. But I don't like really the idea to add new class to input...

The solution you proposed may have side effects because of adding the same class to parent and child.

I understand what you mean, but if you think about, usually a parent invalid class check child, like .has-error .form-control and if .form-control has .has-error it will not impact on style.

I don't see how can impact on style since is never used alone.

Better this than adding custom classes to input.

Looking for your update. Thanks

[thewebartisan7]

Maybe add new options, like classToSelf = true|false when is true, just use field.input, otherwise use classTo

[mikkeltschentscher]

+1

A classToSelf = true|false or an added extra classToInput = 'js-form-input' would be appreciated.
I work with TailwindCSS as my framework of choice and the same applies here :-)

[SasSam]

+1

Any ETA for this fix, @sha256 ?

[TheROPFather]

Also wondering if an update is coming for this

[MirazMac]

any updates regarding this?