add collection group test.

Author: sgr-ksmt

FireSnapshot.xcodeproj/project.pbxproj

@@ -52,6 +52,7 @@
 		1694DF6D234DEC8300B7807A /* BatchTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 1694DF6C234DEC8300B7807A /* BatchTests.swift */; };
 		1694DF6F234DF02E00B7807A /* DocumentTimestampsTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 1694DF6E234DF02E00B7807A /* DocumentTimestampsTests.swift */; };
 		1694DF71234E32DC00B7807A /* ReadTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 1694DF70234E32DC00B7807A /* ReadTests.swift */; };
+		1694DF73234ED43900B7807A /* CollectionGroupTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 1694DF72234ED43900B7807A /* CollectionGroupTests.swift */; };
 		16B699E4234636DD005877A9 /* CollectionGroup.swift in Sources */ = {isa = PBXBuildFile; fileRef = 16B699E3234636DD005877A9 /* CollectionGroup.swift */; };
 		16B699E82348CA80005877A9 /* PathTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 16B699E72348CA80005877A9 /* PathTests.swift */; };
 		C7AC0728461714610F570CB5 /* Pods_FireSnapshotTests.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = BA9C3F24DAB7C0106A5A122D /* Pods_FireSnapshotTests.framework */; };
@@ -117,6 +118,7 @@
 		1694DF6C234DEC8300B7807A /* BatchTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BatchTests.swift; sourceTree = "<group>"; };
 		1694DF6E234DF02E00B7807A /* DocumentTimestampsTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DocumentTimestampsTests.swift; sourceTree = "<group>"; };
 		1694DF70234E32DC00B7807A /* ReadTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ReadTests.swift; sourceTree = "<group>"; };
+		1694DF72234ED43900B7807A /* CollectionGroupTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CollectionGroupTests.swift; sourceTree = "<group>"; };
 		16B699E3234636DD005877A9 /* CollectionGroup.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CollectionGroup.swift; sourceTree = "<group>"; };
 		16B699E72348CA80005877A9 /* PathTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PathTests.swift; sourceTree = "<group>"; };
 		25B42645485A6D1C6682724A /* Pods-FireSnapshot.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-FireSnapshot.debug.xcconfig"; path = "Target Support Files/Pods-FireSnapshot/Pods-FireSnapshot.debug.xcconfig"; sourceTree = "<group>"; };
@@ -220,6 +222,7 @@
 				1694DF6C234DEC8300B7807A /* BatchTests.swift */,
 				1694DF6E234DF02E00B7807A /* DocumentTimestampsTests.swift */,
 				1694DF70234E32DC00B7807A /* ReadTests.swift */,
+				1694DF72234ED43900B7807A /* CollectionGroupTests.swift */,
 			);
 			path = FireSnapshotTests;
 			sourceTree = "<group>";
@@ -485,6 +488,7 @@
 			isa = PBXSourcesBuildPhase;
 			buildActionMask = 2147483647;
 			files = (
+				1694DF73234ED43900B7807A /* CollectionGroupTests.swift in Sources */,
 				1694DF6D234DEC8300B7807A /* BatchTests.swift in Sources */,
 				1694DF67234DD29E00B7807A /* ReferenceTests.swift in Sources */,
 				1694DF5F234D78E800B7807A /* ReplicatedTests.swift in Sources */,

FireSnapshot/Sources/Snapshot+Read.swift

@@ -39,7 +39,7 @@ public extension Snapshot {
         )
     }
 
-    static func get(_ collectionGroup: CollectionGroup<Data>,
+    static func get(collectionGroup: CollectionGroup<Data>,
                     queryBuilder: QueryBuilder = { $0 },
                     source: FirestoreSource = .default,
                     completion: @escaping CollectionReadResultBlock<Data>) {

FireSnapshotTests/CollectionGroupTests.swift

@@ -0,0 +1,93 @@
+//
+// Copyright © Suguru Kishimoto. All rights reserved.
+//
+
+import XCTest
+import FirebaseFirestore
+
+@testable import FireSnapshot
+
+private extension CollectionPaths {
+    static let users = CollectionPath<User>("users")
+    static let tasks = CollectionPath<Task>("tasks")
+    static func groups(for user: DocumentPath<User>) -> CollectionPath<Group> {
+        user.collection("groups")
+    }
+
+    static func groups(for task: DocumentPath<Task>) -> CollectionPath<Group> {
+        task.collection("groups")
+    }
+}
+
+private extension CollectionGroups {
+    static let groups = CollectionGroup<Group>("groups")
+}
+
+private struct User: SnapshotData {
+    var name: String = "Mike"
+}
+
+private struct Task: SnapshotData {
+    var title: String = "task"
+}
+
+private struct Group: SnapshotData {
+    var name: String = "group"
+}
+
+class CollectionGroupTests: XCTestCase {
+
+    override func setUp() {
+        super.setUp()
+        FirebaseTestHelper.setupFirebaseApp()
+    }
+
+    override func tearDown() {
+        super.tearDown()
+        FirebaseTestHelper.deleteFirebaseApp()
+    }
+
+    func testCollectionGroup() {
+        let exp = expectation(description: #function)
+
+        let user = Snapshot(data: .init(), path: .users)
+        let task = Snapshot(data: .init(), path: .tasks)
+
+        let batch = Firestore.firestore().batch()
+        try! batch.create(user)
+        try! batch.create(task)
+        batch.commit { error in
+            if let error = error {
+                XCTFail("\(error)")
+                exp.fulfill()
+                return
+            }
+            let g1 = Snapshot(data: .init(), path: .groups(for: user.path))
+            g1.name = "from user"
+            let g2 = Snapshot(data: .init(), path: .groups(for: task.path))
+            g2.name = "from task"
+            let batch = Firestore.firestore().batch()
+            try! batch.create(g1)
+            try! batch.create(g2)
+
+            batch.commit { error in
+                if let error = error {
+                    XCTFail("\(error)")
+                    exp.fulfill()
+                    return
+                }
+                Snapshot.get(collectionGroup: .groups) { result in
+                    switch result {
+                    case let .success(groups):
+                        XCTAssertEqual(groups.count, 2)
+                        exp.fulfill()
+                    case let .failure(error):
+                        XCTFail("\(error)")
+                        exp.fulfill()
+                    }
+                }
+            }
+        }
+        wait(for: [exp], timeout: 10.0)
+    }
+}

firebase/firestore.rules

@@ -1,3 +1,4 @@
+rules_version = '2';
 service cloud.firestore {
   match /databases/{database}/documents {
     match /mocks/{mockID} {
@@ -15,5 +16,9 @@ service cloud.firestore {
     match /tasks/{taskID} {
       allow read, write;
     }
+
+    match /{path=**}/groups/{groupId} {
+      allow read, write;
+    }
   }
 }