Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite references to node_modules #269

Open
fwextensions opened this issue Feb 11, 2023 · 2 comments
Open

Rewrite references to node_modules #269

fwextensions opened this issue Feb 11, 2023 · 2 comments
Labels
chore General maintenance tasks

Comments

@fwextensions
Copy link
Collaborator

There are several places where paths reference files inside of node_modules. These paths are brittle, as the packages can change, or the package manager can move things around. The files should be imported through the normal mechanisms instead.

@francisli
Copy link
Collaborator

I don't have any ideas on immediate changes/fixes for this...

I think this issue would go away if we re-implement the login page in the SPA client and then these can be compiled into the bundle with webpack.

@fwextensions
Copy link
Collaborator Author

fwextensions commented Feb 13, 2023

Ah, right, the login page is just static files, so it needs a known location for the CSS. I think webpack can rewrite the paths in the static files so they point to a built location, as opposed to fully bringing them into the SPA.

There are also places in the client code where modules are imported from paths inside node_modules, which should be cleaned up as well, mostly around USWDS assets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore General maintenance tasks
Projects
None yet
Development

No branches or pull requests

2 participants