Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with blank icons and inability to change the theme (ver 4.0.0) #123

Open
iG8R opened this issue Jan 1, 2024 · 11 comments
Open

Issues with blank icons and inability to change the theme (ver 4.0.0) #123

iG8R opened this issue Jan 1, 2024 · 11 comments
Assignees
Labels
bug Something isn't working

Comments

@iG8R
Copy link

iG8R commented Jan 1, 2024

The title says for itself.
Here is a screencast.

ArrowDL-Icons-Theme-issues-Video_2024-01-01_17-24-59.webm
  • OS: Microsoft Windows [Version 10.0.19045.2673] 64bit
  • Browser: Firefox 121.0 64bit
  • DownRightNow_firefox_v4.0.0.xpi
  • ArrowDL_v4.0.0_windows-mingw-x64.zip
@setvisible
Copy link
Owner

Hi,

It looks like a missing dll maybe, or a wrong version.

Could you please uninstall completely the application (including dlls), and maybe reinstall from scratch in an empty directory?

On my Windows10 machine, it looks like this:

1

Regards

@iG8R
Copy link
Author

iG8R commented Jan 2, 2024

Hi.
As I mentioned above, I installed the portable version (ArrowDL_v4.0.0_windows-mingw-x64.zip).
I've already "reinstalled"(by deleting previously unpacked files and unpacked new ones from the aforementioned archive) it many times.
Also I genuinely installed ArrowDL from the ArrowDL_x64_Setup-4.0.0.exe file.
But still without any positive results.
Could you advice how could I find "a missing dll maybe, or a wrong version"?

@setvisible
Copy link
Owner

setvisible commented Jan 2, 2024

I changed the keyword that saves the settings of the Fusion style.
Maybe the 4.0 reads the old setting, doesn't find it, and doesn't load the style.

=> Could you please go to Option > Preferences > Interface, and select another style or theme (light theme if you are dark?) and check the result?

PS: in your video I remarked that the icons don't appear in the menu of the web-extension... Something else to investigate...

Thanks

@h4aLkon
Copy link

h4aLkon commented Jan 2, 2024

I have the same problem, under Windows 10 LTSC. Changed to dark theme from light but still no luck. Something's wrong with the latest release. DownZemAll 3.1.0 worked fine. Just curios: Why the name change of a well established project?

@iG8R
Copy link
Author

iG8R commented Jan 2, 2024

@setvisible
Thanks a lot for the advice, but, unfortunately, it doesn't work.
But I noticed one peculiarity in ArrowDL - when yet there is no settings in the registry for ArrowDL, with the first launch ArrowDL shows the "light" theme appearance, but any changes of the "Style and Icons" options always triggers it into the "dark" theme appearance, despite the "Style and Icon" options' settings.

ArrowDL-Icons-Theme-issues-02-Video_2024-01-02_22-37-05.webm

@setvisible
Copy link
Owner

setvisible commented Jan 3, 2024

It seems due to a missing DLL <DIR>/Qt6Svg.dll.

=> the DLL is not directly used by the application itself, but used by the plugin <DIR>/iconengines/qsvgicon.dll.

That's why the application starts, but the plugin doesn't. I'll try to fix it tonight

Cheers,

@setvisible
Copy link
Owner

Just curios: Why the name change of a well established project?

Excellent question. Answer is that I'd like to implement a website soon for it, to make the project more visible. So the first step is to register a domain name. This step requires a short name, easy to write, and easy to pronounce, and available. "Arrow" it's because the icon is an arrow, I like the icon and I don't want to change it :) "DL" for "downloader". There are the first reasons.

Moreover in 2019 the initial project was to replace DownThemAll, that was no more working 2 years after the switch of Firefox to WebExtensions. But since, DTA has continued, and I added support to video and torrent in DZA (mainly for the challenge and my cusiosity about the bittorrent protocol).

Today the project is mature, and it deserves its own name.

++

@setvisible
Copy link
Owner

I updated the v4.0.0, so just download it again, and reinstall it.

=> The Qt6Svg.dll should be present in the install dir now...

@setvisible setvisible added the bug Something isn't working label Jan 3, 2024
@setvisible setvisible self-assigned this Jan 3, 2024
@iG8R
Copy link
Author

iG8R commented Jan 3, 2024

@setvisible
Thank you very much!
Now the icons are visible:)
But the issue with the light theme still exists.
And also there is an issue with icons in the menu of the Firefox add-on.

ArrowDL-Icons-Theme-issues-03-Video_2024-01-03_20-55-09.webm

@setvisible
Copy link
Owner

The other bug can be reproduced with

  • Windows theme : "default theme for applications" set to "Dark"
  • ArrowDL theme set to "Light".

But this is fine if the ArrowDL theme is "Dark" when Windows is "Dark" too.

My guess is that there is a conflict between the Windows theme, the Qt6 theme, and the ArrowDL theme. The "light" theme of ArrowDL uses the default Qt6 theme, and the "dark" theme of ArrowDL adds a specific palette to the Qt6' style. Maybe the "Light" theme of ArrowDL should actually write the palette on top of the Qt6, to ensure the "light" colors are specified even if Windows colorizes in Dark.

PS: Thanks for confirming the SVG fix.

@iG8R
Copy link
Author

iG8R commented Jan 7, 2024

Hi.
Unfortunately, the dark theme issue still exists in version 4.0.1.
How could I help to solve it - is there in ArrowDL some debug mode or something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants