Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we enable merge-queue for this repository? #12

Open
CYBAI opened this issue Jul 17, 2023 · 1 comment
Open

Should we enable merge-queue for this repository? #12

CYBAI opened this issue Jul 17, 2023 · 1 comment

Comments

@CYBAI
Copy link
Member

CYBAI commented Jul 17, 2023

While looking at PRs in this repo, I noticed that we haven't enabled merge-queue for this repo yet.
Because this repo is quite new, it doesn't use bors so it's not listed in the merge-queue migration issue. But, I wonder maybe it's still good to enable merge-queue for this repo, what do you think?

@mukilan
Copy link
Member

mukilan commented Jul 17, 2023

Good point. I'm not sure if the current main workflow is compatible with Merge Queues, which requires it to execute on both pull request and merge_group events. I'll look into this. Also, most of the commits are directly pushed to main branch by the CI job, so I'll have to check if that can coexist with the merge queue branch protections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants