Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make card sizes uniform on the site #291

Open
debo19 opened this issue Dec 14, 2021 · 18 comments · May be fixed by #303 or #307
Open

Make card sizes uniform on the site #291

debo19 opened this issue Dec 14, 2021 · 18 comments · May be fixed by #303 or #307
Labels
area/website good first issue Good for newcomers help wanted Extra attention is needed openforce Issues marked for the OpenForce contest

Comments

@debo19
Copy link
Member

debo19 commented Dec 14, 2021

Description

  • Cards for resources are not of the same size.
  • The blog cards look disorganized.

Expected Behavior

  • Uniformity of grid sizing
  • Equalize the size used in the blog grid (and other grids)

Screenshots
grid

cards

Environment:

  • OS: [e.g. Ubuntu]
  • Browser: [e.g. Chrome, Safari]
  • Version: [e.g. 22]
  • Device: [e.g. laptop, iPhone 8]

[Optional] To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error
@debo19 debo19 added help wanted Extra attention is needed area/website labels Dec 14, 2021
@AnshumanDhiman
Copy link

can I work on this @debo19

@leecalcote
Copy link
Member

Go, @AnshumanDhiman, go!

- your personal cheerleader.

@AnshumanDhiman
Copy link

Thank you lee 😃

@AnshumanDhiman
Copy link

@debo19 I need some help, the cards created are kind off hooked, like there is template for 1 card in the code and we are using it to derive other cards from the same code.
This is creating problem, that If I want to edit a particular card other card will also be affected
image_2021-12-16_010432
What I can think off is to separate every card as there are only 4 cards or can you suggest me anything ?

@debo19
Copy link
Member Author

debo19 commented Dec 16, 2021

@AnshumanDhiman Separating each card will make the code redundant, we will have more posts added in eventually. 🤔 Did you try giving the cards a min-height? We'll probably have to use same sized images and subtitles to make them have similar sizes in this case. Also, we can try aligning the cards vertically to the bottom of the row, then the green part may look aligned.

@warunicorn19 warunicorn19 added the issue/remind progress check label Jan 10, 2022
@github-actions
Copy link

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄 on the project.

@AnshumanDhiman AnshumanDhiman linked a pull request Jan 26, 2022 that will close this issue
1 task
@Nikhil-Ladha
Copy link
Contributor

Any updates on the issue @AnshumanDhiman ?

@AnshumanDhiman
Copy link

@Nikhil-Ladha I am facing issues with refactoring the cards as they all are linked together with a single one like passed on as a prop. As every card has different image dimensions so to customize every card, we have to create each card manually which will increase the code. If anyone can take this issue with a different approach, it will be helpful.

@Nikhil-Ladha
Copy link
Contributor

Thanks for the heads-up @AnshumanDhiman . Let's see if anyone has other ideas.

@Nikhil-Ladha Nikhil-Ladha added good first issue Good for newcomers openforce Issues marked for the OpenForce contest and removed issue/remind progress check labels Mar 4, 2022
@Atif0604
Copy link

Atif0604 commented Mar 7, 2022

Can you please assign me this issue under Openforce

@warunicorn19
Copy link
Member

Go ahead @Atif0604

@Atif0604 Atif0604 linked a pull request Mar 7, 2022 that will close this issue
1 task
@nik132-eng
Copy link

Hi, I am Nikunj Rohit, a contributor to OpenForce 2022. If this issue is still open I would like to work on this issue and try better to enhance it more. I would be making a PR as soon as I am done with resolving the issue. Thank you
@debo19 @warunicorn19 @Nikhil-Ladha

@Akshit42-hue
Copy link

Can I work on this issue @debo19

@debo19
Copy link
Member Author

debo19 commented Mar 24, 2022

@St80ene volunteered to take a look in the last websites call iirc. Were you successful here? If you're not working on this currently, we can pass on the assignment

@St80ene
Copy link

St80ene commented Mar 24, 2022

@Akshit42-hue can handle it if possible since he indicated before me. Although, I was just taking some time to study the code. But it's cool.

@debo19
Copy link
Member Author

debo19 commented Apr 4, 2022

@Akshit42-hue will you be taking this forward from here?

@Akshit42-hue
Copy link

Sure, I will @debo19

@Akshit42-hue Akshit42-hue mentioned this issue Apr 9, 2022
1 task
@nik132-eng
Copy link

if the issue is solved pls close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/website good first issue Good for newcomers help wanted Extra attention is needed openforce Issues marked for the OpenForce contest
Projects
None yet
9 participants