Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add support for .net 6 runtime (closes #614) #615

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maciej-bielecki
Copy link

What did you implement:

Added .net6 runtime version to configs. Without it we were not able to use this runtime in serverless.yml.
Closes #614

How did you implement it:

I've added DOTNET60 to enum Runtime, other necessary structures and register commands so that it can be build.

How can we verify it:

Use runtime: dotnet6.0 in serverless.yml file.
Use project targeting net6.0, also azure functions v4 can be used:

Examples:

  • serverless.yml - provider part
...
provider:
  name: azure
  region: West Europe
  functionApp:
    extensionVersion: '~4'
  runtime: dotnet6.0
 ...
  • .csproj - target version for net6.0
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFramework>net6.0</TargetFramework>
    <AzureFunctionsVersion>v4</AzureFunctionsVersion>
...

Todos:

Note: Run npm run test:ci to run all validation checks on proposed changes

  • Ensure there are no lint errors.
    Validate via npm run lint
    Note: Some reported issues can be automatically fixed by running npm run lint:fix
  • Write tests and confirm existing functionality is not broken.
    Validate via npm test
  • Write documentation
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@alexanderwink
Copy link

Any plans on getting this PR merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for .net 6
2 participants