-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using AmazonCorrettoCryptoProvider plugin on Linux to compute hashes faster #1855
Comments
@lfcnassif Where is the better class to insert this code? Do you think it should be configurable? |
Hi @aberenguel! Maybe in the processing Manager, because there are other places that compute hashes, not sure... I think ExportFileTask would be the one that spend more time with hash computation after HashTask, since it is done for all subitems. Is this provider loaded by the java service provider mechanism? Because AFAIK any provider installed could be used depending on the service loading order, that is non deterministic... I don't remember if there is a way to prioritize a specific provider if it is installed over the other ones, maybe it is possible. |
Yes. Internally the provider is added as the highest-priority. https://github.com/corretto/amazon-corretto-crypto-provider/blob/296f3821ee8436ea8a311709c0a89e198b19466c/src/com/amazon/corretto/crypto/provider/AmazonCorrettoCryptoProvider.java#L448 /**
* Installs the AmazonCorrettoCryptoProvider provider as the highest-priority (i.e. default)
* provider systemwide.
*/
public static void install() {
Security.insertProviderAt(INSTANCE, 1);
} |
Great! Could you take a look if Bouncy Castle dependency uses the same priority? This may cause a conflict or non deterministic behavior... |
The
|
@arisjr, since you use Linux in your processing farm, this should be of your interest. Just put the Linux x86_64 jar below into IPED's plugin folder and it should work, starting with the future IPED 4.2.0 release: |
Ótima notícia. Testaremos assim que disponível! |
As discussed in #1849 , the AmazonCorrettoCryptoProvider could have great performance improvement on Linux.
Using default Provider:
Using
AmazonCorrettoCryptoProvider
:As it is not supported in Windows yet, the jar file could be added in plugin folder. The code to support could be:
The text was updated successfully, but these errors were encountered: