Skip to content

Commit 280cbd5

Browse files
authored
fix: Add close event to fileviewer modals (#1130)
[SBISSUE-15945](https://sendbird.atlassian.net/browse/SBISSUE-15945)
1 parent 83e8589 commit 280cbd5

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/modules/GroupChannel/components/FileViewer/FileViewerView.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ export const FileViewerComponent = ({
7878
disableDelete,
7979
onDownloadClick,
8080
}: FileViewerUIProps) => (
81-
<Modal>
81+
<Modal onClose={onCancel}>
8282
<div className="sendbird-fileviewer" data-testid="sendbird-fileviewer">
8383
<div className="sendbird-fileviewer__header">
8484
<div className="sendbird-fileviewer__header__left">

src/ui/FileViewer/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export const FileViewerComponent = (props: FileViewerComponentProps): ReactEleme
3939
const { stringSet } = useContext(LocalizationContext);
4040

4141
return (
42-
<Modal>
42+
<Modal onClose={onClose}>
4343
<div
4444
className="sendbird-fileviewer"
4545
data-testid="sendbird-fileviewer"

src/ui/Modal/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React, { ReactElement, ReactNode, useContext, MouseEvent, useState, useEffect } from 'react';
1+
import React, { ReactElement, ReactNode, useContext, MouseEvent, useState, useEffect, KeyboardEvent } from 'react';
22
import { createPortal } from 'react-dom';
33

44
import './index.scss';
@@ -87,7 +87,7 @@ export interface ModalProps {
8787
disabled?: boolean;
8888
hideFooter?: boolean;
8989
type?: ButtonTypes;
90-
onClose?: () => void;
90+
onClose?: (e?: MouseEvent | KeyboardEvent) => void;
9191
onSubmit?: (...args: any[]) => void;
9292
renderHeader?: () => ReactElement;
9393
customFooter?: ReactNode;

0 commit comments

Comments
 (0)