Skip to content
This repository has been archived by the owner on Nov 13, 2021. It is now read-only.

feat: Add support for major zero-style initial development #138

Closed
wants to merge 4 commits into from
Closed

feat: Add support for major zero-style initial development #138

wants to merge 4 commits into from

Conversation

mandrean
Copy link

@mandrean mandrean commented May 9, 2019

This PR adds support for major zero as outlined in http://semver.org.

Basically, breaking changes bumps the minor component and all other changes bumps the patch. Major is kept at zero.

Fixes #137.

@mandrean
Copy link
Author

mandrean commented May 9, 2019

Travis CI fails for some reason:
image

image

@mandrean
Copy link
Author

mandrean commented May 9, 2019

Ah I see. The test fixture for initial-release & write-mode assumes that it would go from 0.1.0 to 1.0.0.

I updated them to go from 0.0.0 to 0.1.0 & 0.1.0 to 0.2.0, respectively.

Tests are green now!

@mersinvald
Copy link

+1 for that, it's a natural improvement for Rust ecosystem

@stepankuzmin
Copy link

Any chances for this PR to be merged?

@mikenholt
Copy link

Is there a reason this can't be merged?

@thoward27
Copy link

Any blockers here? We would greatly benefit from this being merged, I am willing to help alleviate any potential blocks

@naturallymitchell
Copy link

I encourage this development.

Copy link

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support the PR to be merged.

@mandrean
Copy link
Author

Anyone with write access who can have a look at this? @schultyy @badboy

@mandrean mandrean closed this Oct 13, 2020
@mandrean mandrean deleted the feat/support-major-zero branch October 13, 2020 00:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect bump when major is v0
8 participants