Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: Update zip name #198

Open
AntoninoBonanno opened this issue Dec 28, 2023 · 0 comments
Open

DOCS: Update zip name #198

AntoninoBonanno opened this issue Dec 28, 2023 · 0 comments

Comments

@AntoninoBonanno
Copy link
Contributor

AntoninoBonanno commented Dec 28, 2023

In the documentation the zip name is my-plugin.zip (<slug>.zip)

* Create a zip file for the plugin (/tmp/wp-release/my-plugin.zip)

but inside code and test the name of zip is package.zip

wordpress/lib/publish.ts

Lines 20 to 28 in e8b42e5

const packageResult = await execa(
zipCommand,
['-qr', path.join(releaseDir, `package.zip`), config.slug],
{
reject: false,
cwd: config.releasePath,
timeout: 30 * 1000,
},
);

expect(files).toContain('package.zip');

and actually the name of the generated zip file is package.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant