-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split "successComment" into two parameters to enable conditional activation of this step #666
Comments
I went through the code and noticed, that with the current configuration there is no way my request would work at all. 51 if (successComment === false) {
52 logger.log("Skip commenting on issues and pull requests.");
53 } else { is done before processing the string into a template at 128 await Promise.all(
129 uniqBy([...prs, ...issues], "number").map(async (issue) => {
130 const body = successComment
131 ? template(successComment)({ ...context, issue })
132 : getSuccessComment(issue, releaseInfos, nextRelease); So I there would be the need to have 2 parameters:
|
Leo383
changed the title
SuccessComment templating in ternary expression
Split "successComment" into two parameters to enable conditional activation of this step
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi everyone,
I want to disable successComments when the release is a prerelease and otherwise I want a custom message.
I have tried to do so via
but the plugin seems to replace some of the brackets with parenthesis yet not all of them, thus creating this error:
Does anyone notice what I am doing wrong or if I am doing something wrong?
I am using semantic-release version 21.0.2
The text was updated successfully, but these errors were encountered: