From 234e4b4a054eb4eb848f14d470b770e1ad33b03c Mon Sep 17 00:00:00 2001 From: Matt Travi Date: Tue, 6 Jun 2023 21:50:52 -0500 Subject: [PATCH] feat(node-versions): raised the minimum required node version to v18 BREAKING CHANGE: the minimum required version of node is now v18 for #247 --- .github/workflows/release.yml | 3 ++- .github/workflows/test.yml | 15 ++++++++++----- package-lock.json | 2 +- package.json | 2 +- 4 files changed, 14 insertions(+), 8 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 6968c69..e5966c2 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -23,7 +23,8 @@ jobs: with: cache: npm node-version: lts/* - - run: npm ci + - run: npm clean-install + - run: npm audit signatures - run: npx semantic-release env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index f10f86a..a36d9f0 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -16,8 +16,9 @@ jobs: strategy: matrix: node-version: - - 14.17 - - 16 + - 18.0.0 + - 19 + - 20 runs-on: ubuntu-latest @@ -28,7 +29,8 @@ jobs: with: node-version: ${{ matrix.node-version }} cache: npm - - run: npm ci + - run: npm clean-install + - run: npm audit signatures - run: npm run test:ci # separate job to set as required in branch protection, @@ -40,9 +42,12 @@ jobs: - uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab # v3 - uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3 with: - node-version: 16 + node-version: lts/* cache: npm - - run: npm ci + - run: npm clean-install - name: Ensure dependencies are compatible with the version of node run: npx ls-engines - run: npm run lint + # https://github.com/lirantal/lockfile-lint#readme + - name: Scan lockfile for security issues + run: npx lockfile-lint --path package-lock.json diff --git a/package-lock.json b/package-lock.json index 741ba75..7bbf0ba 100644 --- a/package-lock.json +++ b/package-lock.json @@ -15,7 +15,7 @@ "xo": "0.39.1" }, "engines": { - "node": ">=14.17" + "node": ">=18" } }, "node_modules/@ampproject/remapping": { diff --git a/package.json b/package.json index 68fc1d5..c6deb1e 100644 --- a/package.json +++ b/package.json @@ -19,7 +19,7 @@ "xo": "0.39.1" }, "engines": { - "node": ">=14.17" + "node": ">=18" }, "files": [ "index.js"