Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Cargo.lock not found #35

Open
waynevanson opened this issue Jan 4, 2023 · 3 comments
Open

[docs] Cargo.lock not found #35

waynevanson opened this issue Jan 4, 2023 · 3 comments

Comments

@waynevanson
Copy link

Hi there, just thought I'd leave this here in case others come across the same error.

This error can occur when a workspace member has a Cargo.lock file but the rest don't. To fix, remove this file from the MEMBER, not for the project.
Workspace members use the project lockfile.

@EricCrosson
Copy link
Contributor

I haven't had the opportunity to dogfood semantic-release-cargo with a Rust workspace yet, so thank you for leaving this note.

@waynevanson
Copy link
Author

I'm happy to contribute this one.

There are two solutions, and I prefer the latter.

  • Remove Cargo.lock from workspace on the users behalf.
  • Print this recommendation as an error, and ask users to remove it.

What is recommended?

@EricCrosson
Copy link
Contributor

Thank you!

I'm still a bit far-removed from this use case, so I'm sure I'm not quite able to think through all the ramifications, but I tend agree with your preference for the latter option. I think it's best to let the user decide how to proceed, and to explicitly signal that choice by modifying the files tracked by git

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants