-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Samsung Galaxy S6 SM-G920T identified as tablet #73
Comments
There are also 2 more models which are shown as tablets.
I debugged function parse in parsers, the problem is that there is no 'Mobile' in user agent, before Safari, so this automatically becomes tablet. I thought that this could be related with screen size and resolution. They are 6.3 inches. |
Another user agent shown as a tablet that should parse as mobile:
|
Attached is a txt file of multiple mobile user agents that are incorrectly being parsed as tablets. |
these device family names were found by running the parser against a Parse.ly internal dataset of user agents the parser had incorrectly identified as mobile. fixes selwin#73
The S6 should be identified as
mobile
instead oftablet
. From my read of the code, it looks like_is_android_tablet
could use some updates.I discovered this while investigating this issue on Parse.ly's open source Android SDK.
The text was updated successfully, but these errors were encountered: