SelectMenu closeOnSelect doesn't work with isMultiSelect

[ahsan-sabir]

[brandongregoryscott]

Looking at the code, I think this was intentional:

evergreen/src/select-menu/src/OptionsList.js

Lines 128 to 141 in 80f4f65

	const handleSelect = useCallback(
	item => {
	if (isSelected(item) && isMultiSelect) {
	onDeselect(item)
	} else {
	onSelect(item)
	}
	if (!isMultiSelect && closeOnSelect) {
	close()
	}
	},
	[onDeselect, isMultiSelect, closeOnSelect, onSelect, isSelected, close]
	)

I'm thinking closing the select menu would lead users to believe they can only select one option, and they wouldn't reopen it to select another.

[ahsan-sabir]

I see it's a feature not a bug 😄

"I'm thinking closing the select menu would lead users to believe they can only select one option, and they wouldn't reopen it to select another."

I don't think that would be a problem since it will only close with explicit closeOnSelect.
My particular use case involves making an expensive api req on each select, so I have to close the select menu and disable it until current req completes.

[brandongregoryscott]

I don't think that would be a problem since it will only close with explicit closeOnSelect.

That's a good point. Looks like we don't default closeOnSelect to true, so this wouldn't break the existing behavior for consumers using the multi-select version, unless they were also trying to use both props together.