From 93fb6a62d3a2a9d209a66cfe1734035cd887cbab Mon Sep 17 00:00:00 2001 From: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Date: Tue, 17 Sep 2024 10:35:52 +0530 Subject: [PATCH] [google sheets] mark batch_size and batch_bytes are non-required field --- .../google-sheets-dev/postSheet.types.ts | 4 ++-- .../google-sheets/postSheet/generated-types.ts | 4 ++-- .../destinations/google-sheets/postSheet/index.ts | 14 +++++++------- .../google-sheets/postSheet2/generated-types.ts | 4 ++-- .../destinations/google-sheets/postSheet2/index.ts | 4 ++-- 5 files changed, 15 insertions(+), 15 deletions(-) diff --git a/packages/destination-actions/src/destinations/google-sheets-dev/postSheet.types.ts b/packages/destination-actions/src/destinations/google-sheets-dev/postSheet.types.ts index cb81efd753..4827c42a32 100644 --- a/packages/destination-actions/src/destinations/google-sheets-dev/postSheet.types.ts +++ b/packages/destination-actions/src/destinations/google-sheets-dev/postSheet.types.ts @@ -43,9 +43,9 @@ export interface Payload { /** * The number of rows to write to the spreadsheet in a single batch. The value is determined by number of rows * columns that Segment can upload within 30s. */ - batch_size: number + batch_size?: number /** * The number of bytes to write to the spreadsheet in a single batch. Limit is 2MB. */ - batch_bytes: number + batch_bytes?: number } diff --git a/packages/destination-actions/src/destinations/google-sheets/postSheet/generated-types.ts b/packages/destination-actions/src/destinations/google-sheets/postSheet/generated-types.ts index cb81efd753..4827c42a32 100644 --- a/packages/destination-actions/src/destinations/google-sheets/postSheet/generated-types.ts +++ b/packages/destination-actions/src/destinations/google-sheets/postSheet/generated-types.ts @@ -43,9 +43,9 @@ export interface Payload { /** * The number of rows to write to the spreadsheet in a single batch. The value is determined by number of rows * columns that Segment can upload within 30s. */ - batch_size: number + batch_size?: number /** * The number of bytes to write to the spreadsheet in a single batch. Limit is 2MB. */ - batch_bytes: number + batch_bytes?: number } diff --git a/packages/destination-actions/src/destinations/google-sheets/postSheet/index.ts b/packages/destination-actions/src/destinations/google-sheets/postSheet/index.ts index 30d3d6344e..ff0824df52 100644 --- a/packages/destination-actions/src/destinations/google-sheets/postSheet/index.ts +++ b/packages/destination-actions/src/destinations/google-sheets/postSheet/index.ts @@ -57,14 +57,14 @@ const action: ActionDefinition = { fields: { label: 'Fields', description: ` - The fields to write to the spreadsheet. + The fields to write to the spreadsheet. + + On the left-hand side, input the name of the field as it will appear in the Google Sheet. - On the left-hand side, input the name of the field as it will appear in the Google Sheet. - On the right-hand side, select the field from your data model that maps to the given field in your sheet. - + --- - + `, type: 'object', required: true, @@ -82,7 +82,7 @@ const action: ActionDefinition = { description: 'The number of rows to write to the spreadsheet in a single batch. The value is determined by number of rows * columns that Segment can upload within 30s.', default: 1001, - required: true, + required: false, unsafe_hidden: true }, batch_bytes: { @@ -90,7 +90,7 @@ const action: ActionDefinition = { label: 'Batch Bytes', description: 'The number of bytes to write to the spreadsheet in a single batch. Limit is 2MB.', default: 2000000, // 2MB, - required: true, + required: false, unsafe_hidden: true } }, diff --git a/packages/destination-actions/src/destinations/google-sheets/postSheet2/generated-types.ts b/packages/destination-actions/src/destinations/google-sheets/postSheet2/generated-types.ts index aff81ff2ed..a61a768927 100644 --- a/packages/destination-actions/src/destinations/google-sheets/postSheet2/generated-types.ts +++ b/packages/destination-actions/src/destinations/google-sheets/postSheet2/generated-types.ts @@ -39,9 +39,9 @@ export interface Payload { /** * The number of rows to write to the spreadsheet in a single batch. The value is determined by number of rows * columns that Segment can upload within 30s. */ - batch_size: number + batch_size?: number /** * The number of bytes to write to the spreadsheet in a single batch. Limit is 2MB. */ - batch_bytes: number + batch_bytes?: number } diff --git a/packages/destination-actions/src/destinations/google-sheets/postSheet2/index.ts b/packages/destination-actions/src/destinations/google-sheets/postSheet2/index.ts index fb1152beb1..d8a8288e29 100644 --- a/packages/destination-actions/src/destinations/google-sheets/postSheet2/index.ts +++ b/packages/destination-actions/src/destinations/google-sheets/postSheet2/index.ts @@ -94,7 +94,7 @@ const action: ActionDefinition = { description: 'The number of rows to write to the spreadsheet in a single batch. The value is determined by number of rows * columns that Segment can upload within 30s.', default: 1001, - required: true, + required: false, unsafe_hidden: true }, batch_bytes: { @@ -102,7 +102,7 @@ const action: ActionDefinition = { label: 'Batch Bytes', description: 'The number of bytes to write to the spreadsheet in a single batch. Limit is 2MB.', default: 2000000, // 2MB, - required: true, + required: false, unsafe_hidden: true } },