more validation

segmentio · Oct 21, 2024 · 4902b18 · 4902b18
1 parent ddeee29
commit 4902b18
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/destination-actions/src/destinations/sendgrid/sendEmail/constants.ts b/packages/destination-actions/src/destinations/sendgrid/sendEmail/constants.ts
@@ -2,7 +2,7 @@ export const RESERVED_HEADERS = ["x-sg-id", "x-sg-eid", "received", "dkim-signat
 
 export const MAX_CATEGORY_LENGTH = 255
 
-export const MAINIP_POOL_NAME_LENGTH = 2
+export const MIN_IP_POOL_NAME_LENGTH = 2
 
 export const MAX_IP_POOL_NAME_LENGTH = 64
 
diff --git a/packages/destination-actions/src/destinations/sendgrid/sendEmail/utils.ts b/packages/destination-actions/src/destinations/sendgrid/sendEmail/utils.ts
@@ -1,7 +1,7 @@
 import { RequestClient, PayloadValidationError } from '@segment/actions-core'
 import type { Payload } from './generated-types'
 import { sendEmailReq } from './types'
-import { RESERVED_HEADERS, MAX_CATEGORY_LENGTH } from './constants'
+import { RESERVED_HEADERS, MAX_CATEGORY_LENGTH, MIN_IP_POOL_NAME_LENGTH, MAX_IP_POOL_NAME_LENGTH } from './constants'
 
 export async function send(request: RequestClient, payload: Payload) {
  validate(payload)
@@ -86,5 +86,9 @@ function validate(payload: Payload){
  }
  }
 
+ if(payload.ipPoolName && (payload.ipPoolName.length >= MAX_IP_POOL_NAME_LENGTH || payload.ipPoolName.length <= MIN_IP_POOL_NAME_LENGTH)) {
+ throw new PayloadValidationError(`IP Pool Name should at least ${MIN_IP_POOL_NAME_LENGTH} characters and at most ${MAX_IP_POOL_NAME_LENGTH} characters in length`)
+ }
+
  return 
 }