Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template creation if non-administrator #1880

Closed
kdp-cloud opened this issue May 15, 2024 · 3 comments · Fixed by #1884
Closed

Template creation if non-administrator #1880

kdp-cloud opened this issue May 15, 2024 · 3 comments · Fixed by #1884
Assignees
Labels
Projects
Milestone

Comments

@kdp-cloud
Copy link
Collaborator

A User cannot create templates unless he administers at least 1 project. Any user should be able to create a template, regardless if the user is administrating anything.

@kdp-cloud kdp-cloud added the bug label May 15, 2024
@kdp-cloud kdp-cloud self-assigned this May 15, 2024
@kdp-cloud kdp-cloud added this to To do in SEEK 1.15.x via automation May 15, 2024
@kdp-cloud
Copy link
Collaborator Author

@floradanna I found the cause of this behavior. But it explicitly says you need to be instance admin or a project admin.

can && User.current_user.is_admin_or_project_administrator?

Do you want me to revert that?

@floradanna
Copy link
Collaborator

I am checking old notes before I can answer. @NielsGeudens what do you think.
What I can say is that if only admin can create template, they must be admin of that specific project (not admin of any project). So, in case, project admin can create templates only for the projects they administer.

@kdp-cloud
Copy link
Collaborator Author

@floradanna, @NielsGeudens
So to conclude our conversation, the default behavior would be (for now) that you do need to be at least administrator of one project to create a template, but you can only make project specific templates in projects you administer and not all projects you are member of.

Examples:

  • User A administers project X and is simply a member of projects Y and Z. User A can only create project specific templates for project X and not Y or Z.
  • User B is member of projects X, Y and Z but doesn't administer any of them. User B will be denied to create any template.

Is this the desired behavior?

@kdp-cloud kdp-cloud added this to the 1.15.1 milestone May 16, 2024
@kdp-cloud kdp-cloud linked a pull request May 16, 2024 that will close this issue
SEEK 1.15.x automation moved this from To do to Done Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging a pull request may close this issue.

2 participants