Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to build playroom without a favicon #311

Closed
jordanoverbye opened this issue Jan 2, 2024 · 1 comment · Fixed by #314
Closed

Unable to build playroom without a favicon #311

jordanoverbye opened this issue Jan 2, 2024 · 1 comment · Fixed by #314

Comments

@jordanoverbye
Copy link
Contributor

jordanoverbye commented Jan 2, 2024 •
edited
Loading

I'm unable to run playroom build after upgrading to 0.34.1. I'm getting the following error:

Error: HtmlWebpackPlugin: could not load file /path/to/repo/images/favicon.png
- index.js:494      [repo]/[html-webpack-plugin]/index.js:494:35     error Command failed with exit code 1.

This seems to have been caused by PR #309

If I create a images/favicon.png file everything works correctly, but this seems unexpected for a patch release.
@jordanoverbye jordanoverbye changed the title Unable to build plau Unable to build playroom without a favicon Jan 2, 2024
@jordanoverbye jordanoverbye mentioned this issue Jan 2, 2024
Closed
@askoufis askoufis mentioned this issue Jan 24, 2024
Merged
@mrm007
Copy link
Contributor

mrm007 commented Jan 24, 2024

@jordanoverbye does this snapshot work for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix playroom build by making favicon path relative to webpack config seek-oss/playroom
2 participants
@mrm007 @jordanoverbye