From 7b4b2f050945015e1bdaeda273da39baae8f6566 Mon Sep 17 00:00:00 2001 From: Anto Lepejian <35133032+AntoLepejian@users.noreply.github.com> Date: Fri, 15 Nov 2024 18:00:53 +1100 Subject: [PATCH] Tighten webpack rule merge rules to prevent clashes (#376) Co-authored-by: Adam Skoufis --- .changeset/nasty-brooms-brush.md | 7 +++++++ lib/makeWebpackConfig.js | 2 ++ 2 files changed, 9 insertions(+) create mode 100644 .changeset/nasty-brooms-brush.md diff --git a/.changeset/nasty-brooms-brush.md b/.changeset/nasty-brooms-brush.md new file mode 100644 index 00000000..7b628863 --- /dev/null +++ b/.changeset/nasty-brooms-brush.md @@ -0,0 +1,7 @@ +--- +'playroom': patch +--- + +Tighten webpack config merge rules to prevent replacing playroom webpack config with user-provided webpack config + +When merging user-provided webpack config, a module rule's `test`, `include` and `exclude` property will all be compared. diff --git a/lib/makeWebpackConfig.js b/lib/makeWebpackConfig.js index 0179abe9..78eb61e9 100644 --- a/lib/makeWebpackConfig.js +++ b/lib/makeWebpackConfig.js @@ -205,6 +205,8 @@ module.exports = async (playroomConfig, options) => { module: { rules: { test: 'match', + include: 'match', + exclude: 'match', use: 'replace', }, },