Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sslyze scanner: Add mozilla compliance check to the findings #2099

Open
Urth opened this issue Nov 15, 2023 · 1 comment
Open

sslyze scanner: Add mozilla compliance check to the findings #2099

Urth opened this issue Nov 15, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Urth
Copy link

Urth commented Nov 15, 2023

➹ New Feature implementation request

Is your feature request related to a problem?

https://www.securecodebox.io/docs/scanners/sslyze#examples

The documentation for the SSLyze scanner shows many examples using the --mozilla_config=intermediate parameter. But the reality is that the --mozilla_config parameter has no effect on the findings reported by the scanner. SSLyze performs the same scan regardless of the --mozilla_config parameter and validates the scan against the requested compliance level after the json output has been generated.
https://github.com/nabla-c0d3/sslyze/blob/release/sslyze/__main__.py#L89
https://github.com/search?q=repo%3Anabla-c0d3%2Fsslyze%20check_against_mozilla_config&type=code

The mozilla compliance check result can only be read from the logs of the scanner pod which is very inconvenient.

The SSLyze examples set the wrong expectation with the --mozilla_config parameter.

Describe the solution you'd like

I would like to have the scanner include mozilla compliance validation in the findings.

Describe alternatives you've considered

Requesting the compliance level to be included in the SSLyze json output.
Because the scan does not change it should even be possible to check if the target matches any compliance level and report that.

@Urth Urth added the enhancement New feature or request label Nov 15, 2023
@Weltraumschaf
Copy link
Member

@Urth Thanksfor submitting this issue. We will investigate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants