-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --gitignore option #337
Labels
Status: Proposal
Request for comments
Comments
Closed
📝 I received a message that current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Secretlint has used globby and globby has gitignore option.
It is useful that user can use
secretlint --gitignore "**/*"
instead ofsecretlint --secretlintignore .gitignore "**/*"
.Basic example
If use want to respect gitinore,
--gitignore
enable this feature.This feature should be opt-in, as some secrets may already be included under git.
Ref #204 (comment)
Motivation
secretlint --secretlintignore .gitignore
is not intuitive.Also,
secretlint --secretlintignore .gitignore
disable.secretlintignore
secretlint --gitignore
respects.gitignore
and.secretlintignore
.Additionally, gitignore option will cover edge case. It is more safe.
Naming
We need to think easy to understand name.
--gitignore
: Respect.gitignore
fileAnother option:
globby has ignoreFiles option.
Memo
I do not known if the gitignore option respects cascaded
.gitignore
files.The text was updated successfully, but these errors were encountered: