Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Water parameters not applying when Transparent Water is disabled #3557

Open
AtlasLinden opened this issue Feb 13, 2025 · 1 comment · Fixed by #3571
Open

Water parameters not applying when Transparent Water is disabled #3557

AtlasLinden opened this issue Feb 13, 2025 · 1 comment · Fixed by #3571
Assignees
@Geenz @akleshchev
Labels
add-to-regression-test bug Something isn't working team:viewer
Milestone
2024.12-ForeverFPS

Comments

@AtlasLinden
Copy link

AtlasLinden commented Feb 13, 2025 •
edited
Loading

Environment

ForeverFPS 7.1.12.13313961408

Description

Water is appearing flat with no reflections or normal map when Transparent Water is disabled.
Following images show ForeverFPS (left) vs ExtraFPS (right)

Image

Image

Reproduction steps

  1. Disable Transparent Water
  2. Observe water
@AtlasLinden AtlasLinden added bug Something isn't working triage Flags issues that need to be triaged labels Feb 13, 2025
@kylelinden kylelinden added this to the 2024.12-ForeverFPS milestone Feb 14, 2025
@kylelinden kylelinden added team:viewer and removed triage Flags issues that need to be triaged labels Feb 14, 2025
@akleshchev
Copy link
Contributor

Broke after 93a88e6

akleshchev added a commit that referenced this issue Feb 17, 2025
@akleshchev
#3557 Waves not applying withou Transparent Water
6516d14
akleshchev added a commit that referenced this issue Feb 17, 2025
@akleshchev
#3557 Waves not applying without Transparent Water
049b119
akleshchev added a commit that referenced this issue Feb 18, 2025
@akleshchev
#3557 Waves not applying without Transparent Water
9b0c167
@akleshchev akleshchev linked a pull request Feb 18, 2025 that will close this issue
#3557 Waves not applying without Transparent Water #3571
Merged
@AtlasLinden AtlasLinden mentioned this issue Feb 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Geenz Geenz

@akleshchev akleshchev

Labels
add-to-regression-test bug Something isn't working team:viewer
Projects
None yet
Milestone
2024.12-ForeverFPS
Development

Successfully merging a pull request may close this issue.

#3557 Waves not applying without Transparent Water secondlife/viewer
5 participants
@Geenz @kylelinden @AtlasLinden @akleshchev @Dan-Linden