string instead of boolean

Author: christophdb

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 1.6.1 (2.9.2025)
+
+- use always string (instead of boolean) for true and false
+
 ## 1.6.0 (12.05.2025)
 
 - updated software versions and debian base image

entry.sh

@@ -46,7 +46,7 @@ log "DEBUG" "MSMTP_ARGS: ${MSMTP_ARGS}"
 log "DEBUG" "HEALTHCHECK_URL: ${HEALTHCHECK_URL}"
 log "DEBUG" "USER_AGENT: ${USER_AGENT}"
 
-if [ "${RESTIC_SKIP_INIT}" == true ]; then
+if [ "${RESTIC_SKIP_INIT}" = "true" ]; then
     log "INFO" "Skip restic init"
 else
     log "DEBUG" "Check if restic repository exists, otherwise initialize."

log.sh

@@ -2,25 +2,31 @@
 # $LOG_LEVEL is the requested log level of the container, defined by the user in the ENV_VARIABLES
 # $LEVEL is the level of the log message.
 
+set_default() {
+  local var_name=$1
+  local default_value=$2
+  export "$var_name"="${!var_name:-$default_value}"
+}
+
 # set default values for all other environment variables
-export BACKUP_CRON=${BACKUP_CRON:="20 2 * * *"}
-export CHECK_CRON=${CHECK_CRON:="40 3 * * 6"}
-export LOG_LEVEL=${LOG_LEVEL:="INFO"}
-export LOG_TYPE=${LOG_TYPE:="stdout"}
-export RESTIC_TAG=${RESTIC_TAG:="seatable"}
-export RESTIC_DATA_SUBSET=${RESTIC_DATA_SUBSET:="1G"}
-export RESTIC_FORGET_ARGS=${RESTIC_FORGET_ARGS:=""}
-export RESTIC_JOB_ARGS=${RESTIC_JOB_ARGS:=""}
-export RESTIC_SKIP_INIT=${RESTIC_SKIP_INIT:="false"}
-export DATABASE_DUMP=${DATABASE_DUMP:="false"}
-export DATABASE_HOST=${DATABASE_HOST:="mariadb"}
-export DATABASE_USER=${DATABASE_USER:="root"}
-export DATABASE_LIST=${DATABASE_LIST:=""}
-export DATABASE_DUMP_COMPRESSION=${DATABASE_DUMP_COMPRESSION:="false"}
-export SEATABLE_BIGDATA_DUMP=${SEATABLE_BIGDATA_DUMP:="false"}
-export SEATABLE_BIGDATA_HOST=${SEATABLE_BIGDATA_HOST:="seatable-server"}
-export HEALTHCHECK_URL=${HEALTHCHECK_URL:=""}
-export USER_AGENT=${USER_AGENT:="restic-backup-docker/1.6.0"}
+set_default BACKUP_CRON "20 2 * * *"
+set_default CHECK_CRON "40 3 * * 6"
+set_default LOG_LEVEL "INFO"
+set_default LOG_TYPE "stdout"
+set_default RESTIC_TAG "seatable"
+set_default RESTIC_DATA_SUBSET "1G"
+set_default RESTIC_FORGET_ARGS ""
+set_default RESTIC_JOB_ARGS ""
+set_default RESTIC_SKIP_INIT false
+set_default DATABASE_DUMP false
+set_default DATABASE_HOST "mariadb"
+set_default DATABASE_USER "root"
+set_default DATABASE_LIST ""
+set_default DATABASE_DUMP_COMPRESSION "false"
+set_default SEATABLE_BIGDATA_DUMP "false"
+set_default SEATABLE_BIGDATA_HOST "seatable-server"
+set_default HEALTHCHECK_URL ""
+set_default USER_AGENT "restic-backup-docker/1.6.1"
 
 log() {
     local LEVEL="$1"

pre-default.sh

@@ -13,7 +13,7 @@ command_exists() {
 }
 
 # DATABASE DUMP
-if [ "${DATABASE_DUMP}" == true ] || [ "${SEATABLE_DATABASE_DUMP}" == true ]; then
+if [ "${DATABASE_DUMP}" = "true" ] || [ "${SEATABLE_DATABASE_DUMP}" = "true" ]; then
 
     log "DEBUG" "Check for correct dump command"
     # Check for mysqldump or mariadb-dump
@@ -41,7 +41,7 @@ if [ "${DATABASE_DUMP}" == true ] || [ "${SEATABLE_DATABASE_DUMP}" == true ]; th
     fi
 
     # compress the dump files
-    if [ "${DATABASE_DUMP_COMPRESSION}" == true ]; then
+    if [ "${DATABASE_DUMP_COMPRESSION}" = "true" ]; then
         log "INFO" "Compressing dump files"
         find /data/database-dumps -name "*.dump" -type f -exec gzip -f {} +
         log "DEBUG" "Compression complete"
@@ -53,7 +53,7 @@ else
 fi
 
 # BIG DATA DUMP
-if [ "${SEATABLE_BIGDATA_DUMP}" == true ]; then
+if [ "${SEATABLE_BIGDATA_DUMP}" == "true" ]; then
     log "INFO" "Dump big data"
     /usr/local/bin/docker exec ${SEATABLE_BIGDATA_HOST} /opt/seatable/scripts/seatable.sh backup-all
     log "INFO" "Dump finished"