refactor: fix editor event handlers

Author: SailingBoat762

src/DTableColumnIcon/index.jsx

@@ -34,15 +34,16 @@ const COLUMNS_ICON_CONFIG = {
   [CellType.DEPARTMENT_SINGLE_SELECT]: 'dtable-font dtable-icon-department-single-selection',
 };
 
-const COLUMN_DISPLAY_TYPE_ICON_CONFIG = {
-  [CellType.TEXT]: {
-    [TEXT_DISPLAY_TYPE_MAP.PHONE]: 'telephone',
-  }
-};
-
 const DTableColumnIcon = ({ column, color, className, ariaHidden = false, getSvg }) => {
   const columnType = column?.type;
   if (!columnType) return null;
+
+  const COLUMN_DISPLAY_TYPE_ICON_CONFIG = {
+    [CellType.TEXT]: {
+      [TEXT_DISPLAY_TYPE_MAP.PHONE]: 'telephone',
+    }
+  };
+
   const columnDisplayType = getColumnDisplayType(column);
   let symbol = null;
   let displayTypeIconConfig = COLUMN_DISPLAY_TYPE_ICON_CONFIG[columnType];

src/DTableFiltersPopover/widgets/filter-item.js

@@ -215,19 +215,17 @@ class FilterItem extends React.Component {
   };
 
   onFilterTermCheckboxChanged = () => {
-    const { filterColumn } = this.props;
-    const value = this.checkboxEditor.getValue();
-    const checked = value[filterColumn.key];
-    this.onFilterTermChanged(checked);
+    const value = this.checkboxEditor?.getValue();
+    this.onFilterTermChanged(!!value);
   };
 
   onFilterTermTextChanged = (value) => {
     this.onFilterTermChanged(value);
   };
 
   onFilterTermNumberChanged = () => {
-    const value = this.numberEditor.getValue();
-    this.onFilterTermChanged(Object.values(value)[0]);
+    const value = this.numberEditor?.getValue();
+    this.onFilterTermChanged(value);
   };
 
   onFilterTermDurationChanged = () => {
@@ -278,7 +276,7 @@ class FilterItem extends React.Component {
             column={filterColumn}
             value={filterTerm}
             className='dtable-ui-filter-item-checkbox'
-            onChange={this.onFilterTermCheckboxChanged}
+            onCommit={this.onFilterTermCheckboxChanged}
             readOnly={readOnly}
           />
         </div>

src/NumberEditor/index.js

@@ -59,7 +59,11 @@ class NumberEditor extends React.Component {
   };
 
   onBlur = () => {
-    this.props.isInModal ? this.props.onCommit(this.getValue()) : this.props.onBlur();
+    if (this.props.onCommit) {
+      this.props.onCommit(this.getValue());
+    } else if (this.props.onBlur) {
+      this.props.onBlur();
+    }
   };
 
   setInputRef = (input) => {