Allow null

seamapi · Apr 10, 2024 · 32cadae · 32cadae
1 parent 73ed605
commit 32cadae
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 3 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -30,7 +30,8 @@ const isSerializable = (obj: Record<any, any>): boolean => {
  typeof val === "string" ||
  typeof val === "boolean" ||
  typeof val === "number" ||
- val.constructor === Date ||
+ val?.constructor === Date ||
+ val === null ||
  Array.isArray(val) ||
  isPlainObject(val)
  )

diff --git a/src/tests/hooks.test.ts b/src/tests/hooks.test.ts
@@ -126,15 +126,27 @@ test("beforeTemplateIsBaked (propagates error that isn't serializable)", async (
 
 test("beforeTemplateIsBaked (result isn't serializable)", async (t) => {
  type HookReturn = {
- type: "function" | "date"
+ type: "function" | "date" | null
  }
 
  const getTestServer = getTestPostgresDatabaseFactory<HookReturn>({
  postgresVersion: process.env.POSTGRES_VERSION,
  workerDedupeKey: "beforeTemplateIsBakedHookNonSerializable",
  beforeTemplateIsBaked: async ({ params: { type } }) => {
+ if (type === "function") {
+ return {
+ foo: () => "bar",
+ }
+ }
+
+ if (type === "date") {
+ return {
+ foo: new Date(),
+ }
+ }
+
  return {
- foo: type === "function" ? () => "bar" : new Date(),
+ foo: null,
  }
  },
  })
@@ -154,6 +166,12 @@ test("beforeTemplateIsBaked (result isn't serializable)", async (t) => {
  type: "date",
  })
  t.true(beforeTemplateIsBakedResult.foo instanceof Date)
+
+ // Can return null
+ const { beforeTemplateIsBakedResult: result } = await getTestServer(t, {
+ type: null,
+ })
+ t.is(result.foo, null)
 })
 
 test("beforeTemplateIsBaked with manual template build", async (t) => {