Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget msgs bug: a negative bye confirmation would not disable past widgets of the same kind #71

Open
ojcchar opened this issue Aug 3, 2021 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@ojcchar
Copy link
Contributor

ojcchar commented Aug 3, 2021

This is for widget chatbot messages that display options (e.g., screenshots) that the user should select.

When the user says no to a bye confirmation of the chatbot, right after a widget message is displayed, the chatbot will display the same widget message (i.e., the new message); however, the past widget would not be disabled, which means the user can still select options from it, and this can cause errors in the conversation flow.

We can reproduce this by saying bye after the list of apps are shown for selection, then, we can see that both widget messages (listing the apps) are enabled, so I can use any and the other one will remain enabled (it shouldn't, it should be disabled).

One possible solution is to disable the past widget message in the react front end. However, I am not sure how to do this in react.

@bee-tool bee-tool bot added the enhancement New feature or request label Aug 3, 2021
@ojcchar ojcchar added the bug Something isn't working label Aug 3, 2021
@ojcchar
Copy link
Contributor Author

ojcchar commented Aug 3, 2021

This one has low priority for now.

@ojcchar
Copy link
Contributor Author

ojcchar commented Aug 3, 2021

Another potential solution is to have a token that is generated by the server for each widget message.
The server will keep a "current" token, which is the next expected token by the server.
If the token of a widget matches the one from the server, checked in the chatbot GUI (by sending a token verification request to the server), then it will process the message (i.e., send the msg to the server, etc).
Otherwise, the GUI will ignore the event for this widget and potentially display an alert for the user telling her that this widget cannot be used anymore.

ojcchar added a commit that referenced this issue Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant