From bbbb168e379930d15e174ac3a86102ae3ab70bb6 Mon Sep 17 00:00:00 2001 From: fans2619 Date: Thu, 23 Jun 2022 15:26:14 +0800 Subject: [PATCH] Upgrade to Java 17 --- .github/workflows/gradle.yml | 4 ++-- build.gradle | 4 ++-- docs/SettingUp.md | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/gradle.yml b/.github/workflows/gradle.yml index aabbbdba..ccd51b7c 100644 --- a/.github/workflows/gradle.yml +++ b/.github/workflows/gradle.yml @@ -29,10 +29,10 @@ jobs: - name: Validate Gradle Wrapper uses: gradle/wrapper-validation-action@v1 - - name: Setup JDK 11 + - name: Setup JDK 17 uses: actions/setup-java@v1 with: - java-version: '11' + java-version: '17' java-package: jdk+fx - name: Build and check with Gradle diff --git a/build.gradle b/build.gradle index 46bdf94c..a37ae1c0 100644 --- a/build.gradle +++ b/build.gradle @@ -8,8 +8,8 @@ plugins { mainClassName = 'seedu.address.Main' -sourceCompatibility = JavaVersion.VERSION_11 -targetCompatibility = JavaVersion.VERSION_11 +sourceCompatibility = JavaVersion.VERSION_17 +targetCompatibility = JavaVersion.VERSION_17 repositories { mavenCentral() diff --git a/docs/SettingUp.md b/docs/SettingUp.md index 275445bd..9f832a19 100644 --- a/docs/SettingUp.md +++ b/docs/SettingUp.md @@ -19,7 +19,7 @@ Follow the steps in the following guide precisely. Things will not work out if y First, **fork** this repo, and **clone** the fork into your computer. If you plan to use Intellij IDEA (highly recommended): -1. **Configure the JDK**: Follow the guide [_[se-edu/guides] IDEA: Configuring the JDK_](https://se-education.org/guides/tutorials/intellijJdk.html) to to ensure Intellij is configured to use **JDK 11**. +1. **Configure the JDK**: Follow the guide [_[se-edu/guides] IDEA: Configuring the JDK_](https://se-education.org/guides/tutorials/intellijJdk.html) to ensure Intellij is configured to use **JDK 17**. 1. **Import the project as a Gradle project**: Follow the guide [_[se-edu/guides] IDEA: Importing a Gradle project_](https://se-education.org/guides/tutorials/intellijImportGradleProject.html) to import the project into IDEA.
:exclamation: Note: Importing a Gradle project is slightly different from importing a normal Java project. 1. **Verify the setup**: