You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please indicate the following details about the environment in which you found the bug:
SDMetrics version: 0.3.2
Python version: 3.7
Error Description
When using sdmetrics.compute_metrics we get None for metrics that were not able to resolve keyword arguments. In most cases, we expect the user to pass a dictionary for metrics to compute_metrics but if the signature of these metrics differ, we get an error that causes us to catch it then store None in its location.
For example, take the following two time series metrics TSFCDetection and TSFClassifierEfficacy. The first one is expected to be called with
Environment Details
Please indicate the following details about the environment in which you found the bug:
Error Description
When using
sdmetrics.compute_metrics
we getNone
for metrics that were not able to resolve keyword arguments. In most cases, we expect the user to pass a dictionary formetrics
tocompute_metrics
but if the signature of these metrics differ, we get an error that causes us to catch it then storeNone
in its location.For example, take the following two time series metrics
TSFCDetection
andTSFClassifierEfficacy
. The first one is expected to be called withand the second one with an additional argument
target
compute_metrics
will passtarget
to both classes whichTSFCDetection
cannot handle, thus crashing.Steps to reproduce
The text was updated successfully, but these errors were encountered: