Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate input data types for single column and column pair metrics #168

Open
katxiao opened this issue Jul 20, 2022 · 0 comments
Open

Validate input data types for single column and column pair metrics #168

katxiao opened this issue Jul 20, 2022 · 0 comments
Labels
feature request Request for a new feature

Comments

@katxiao
Copy link
Contributor

katxiao commented Jul 20, 2022

Problem Description

The ColumnPairMetric and SingleColumnMetric metrics should verify that the input data is of the expected data type for the metric, and raise a user-friendly error if not. Currently, the expected data types for each metric are specified on the single-table metric level. There is little validation of the input data within the column metric itself. If a user were to directly call the column pair or single column metric with unsuitable data, the behavior is currently unpredictable.

Expected behavior

A user-friendly error should be returned when data of an incompatible data type is passed into a single column or column pair metric.

@katxiao katxiao added the feature request Request for a new feature label Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

1 participant