Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore other statistical tests for numerical columns #128

Open
fealho opened this issue May 19, 2022 · 1 comment
Open

Explore other statistical tests for numerical columns #128

fealho opened this issue May 19, 2022 · 1 comment
Labels
feature request Request for a new feature

Comments

@fealho
Copy link
Member

fealho commented May 19, 2022

Currently SDMetrics only provides the two samples KS test to compare numerical values. We should consider adding other tests as an optional parameter, so the user can choose a test which better matches their understanding of their data.

Additionally, we should explore substituting the KS test with the Anderson-Darling test as the default, since it is a more powerful test overall. Such change would require experimentation to show that the AD test indeed outperforms the KS test in most use cases.

@fealho fealho added new feature pending review This issue needs to be further reviewed, so work cannot be started labels May 19, 2022
@npatki npatki removed the pending review This issue needs to be further reviewed, so work cannot be started label Jul 14, 2022
@npatki npatki changed the title Adding other statistical tests Explore other statistical tests for numerical columns Jul 14, 2022
@npatki npatki added feature request Request for a new feature and removed new feature labels Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

3 participants